Closed
Bug 1362516
Opened 7 years ago
Closed 7 years ago
Bug 1329737 broke TSAN build on linux
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: bwc, Assigned: froydnj)
References
Details
Attachments
(1 file)
1.34 KB,
patch
|
rillian
:
review+
|
Details | Diff | Splinter Review |
I'm seeing the following error: error: couldn't read "/home/bcampen/checkouts/mozilla-inbound/objdir-ff-tsan/toolkit/library/x86_64-unknown-linux-gnu/release/build/gleam-5d435a5e91c26082/out/gl_and_gles_bindings.rs": No such file or directory (os error 2) --> /home/bcampen/checkouts/mozilla-inbound/third_party/rust/gleam/src/lib.rs:16:5 | 16 | include!(concat!(env!("OUT_DIR"), "/gl_and_gles_bindings.rs")); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Backing out the patches from bug 1329737 (on a changeset shortly after they landed) fixes this error. It seems that a file isn't getting staged for tsan builds.
Assignee | ||
Comment 1•7 years ago
|
||
We disable bug 1329737 on ASan builds; we should probably do the same thing for TSan builds, unless we can figure out why passing TSan flags into the linker that Cargo invokes breaks things in peculiar ways.
Assignee | ||
Comment 2•7 years ago
|
||
For all the same reasons as why we disable the linker for ASan builds. Does this work, Byron?
Attachment #8864979 -
Flags: feedback?(docfaraday)
Reporter | ||
Comment 3•7 years ago
|
||
That seems to have done the trick! Thanks!
Assignee | ||
Updated•7 years ago
|
Attachment #8864979 -
Flags: review?(giles)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → nfroyd
Comment 4•7 years ago
|
||
Comment on attachment 8864979 [details] [diff] [review] disable custom Cargo linker for TSan builds Review of attachment 8864979 [details] [diff] [review]: ----------------------------------------------------------------- FWIW, rustc has experimental sanitizer support. Someone might want to experiment with this and RUSTFLAGS=-Z sanitizer=foo. In a different bug, of course.
Attachment #8864979 -
Flags: review?(giles) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1c03cb9ed456 disable custom Cargo linker for TSan builds; r=rillian,f=bwc
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1c03cb9ed456
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee | ||
Updated•7 years ago
|
Attachment #8864979 -
Flags: feedback?(docfaraday)
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•