1362516 - Bug 1329737 broke TSAN build on linux

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Byron Campen [:bwc]]

I'm seeing the following error:

error: couldn't read "/home/bcampen/checkouts/mozilla-inbound/objdir-ff-tsan/toolkit/library/x86_64-unknown-linux-gnu/release/build/gleam-5d435a5e91c26082/out/gl_and_gles_bindings.rs": No such file or directory (os error 2)
  --> /home/bcampen/checkouts/mozilla-inbound/third_party/rust/gleam/src/lib.rs:16:5
   |
16 |     include!(concat!(env!("OUT_DIR"), "/gl_and_gles_bindings.rs"));
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^


Backing out the patches from bug 1329737 (on a changeset shortly after they landed) fixes this error. It seems that a file isn't getting staged for tsan builds.

Comment 1

[Nathan Froyd [:froydnj]]

We disable bug 1329737 on ASan builds; we should probably do the same thing for TSan builds, unless we can figure out why passing TSan flags into the linker that Cargo invokes breaks things in peculiar ways.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: disable custom Cargo linker for TSan builds

For all the same reasons as why we disable the linker for ASan builds.

Does this work, Byron?

Comment 3

[Byron Campen [:bwc]]

That seems to have done the trick! Thanks!

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8864979 [details] [diff] [review]
disable custom Cargo linker for TSan builds

Review of attachment 8864979 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, rustc has experimental sanitizer support. Someone might want to experiment with this and RUSTFLAGS=-Z sanitizer=foo. In a different bug, of course.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c03cb9ed456
disable custom Cargo linker for TSan builds; r=rillian,f=bwc

Comment 6

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/1c03cb9ed456