Open Bug 1362533 Opened 7 years ago Updated 1 year ago

1.0ms uninterruptible reflow at PT__onDragOver@chrome://browser/content/places/browserPlacesViews.js:1600:11

Categories

(Firefox :: Bookmarks & History, defect, P3)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect

Tracking

()

Project Flags:
Performance Impact low

People

(Reporter: rjward0, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: perf, Whiteboard: [ohnoreflow][fxperf:p5][snt-scrubbed][places-performance]) 

Here's the stack:

PT__onDragOver@chrome://browser/content/places/browserPlacesViews.js:1600:11
PT_handleEvent@chrome://browser/content/places/browserPlacesViews.js:1133:9

browserPlacesViews.js:1600: 

      let halfInd = ind.clientWidth / 2;
Component: Untriaged → Bookmarks & History
Flags: qe-verify?
Priority: -- → P2
related stack?

PT__onDragOver@chrome://browser/content/places/browserPlacesViews.js:1628:38
PT_handleEvent@chrome://browser/content/places/browserPlacesViews.js:1133:9
EventListener.handleEvent*PVB__addEventListeners@chrome://browser/content/places/browserPlacesViews.js:917:7
PlacesToolbar@chrome://browser/content/places/browserPlacesViews.js:953:3
PTH_init@chrome://browser/content/browser-places.js:1123:5
_delayedStartup@chrome://browser/content/browser.js:1452:5
EventListener.handleEvent*onLoad@chrome://browser/content/browser.js:1239:5
onload@chrome://browser/content/browser.xul:1:1

bowserPlacesViews.js:1628:

      ind.style.marginInlineStart = (-ind.clientWidth) + "px";
Whiteboard: [ohnoreflow][qf][photon-performance] → [ohnoreflow][qf:p3][photon-performance]
Priority: P2 → P3
Whiteboard: [ohnoreflow][qf:p3][photon-performance] → [ohnoreflow][qf:p3][reserve-photon-performance]
Flags: qe-verify? → qe-verify-
Priority: P3 → P4
Keywords: perf
Priority: P4 → P3
Whiteboard: [ohnoreflow][qf:p3][reserve-photon-performance] → [ohnoreflow][qf:p3][fxperf]
Whiteboard: [ohnoreflow][qf:p3][fxperf] → [ohnoreflow][qf:p3][fxperf:p5]
Performance Impact: --- → P3
Whiteboard: [ohnoreflow][qf:p3][fxperf:p5] → [ohnoreflow][fxperf:p5]
Severity: normal → S3

This is still valid and happening during drag&drop sessions on the Bookmarks Toolbar.
https://searchfox.org/mozilla-central/rev/cdddec7fd690700efa4d6b48532cf70155e0386b/browser/components/places/content/browserPlacesViews.js#1796
We could try using getBoundsWithoutFlush or similar helpers.

Whiteboard: [ohnoreflow][fxperf:p5] → [ohnoreflow][fxperf:p5][snt-scrubbed][places-performance]
You need to log in before you can comment on or make changes to this bug.