Closed
Bug 1362598
Opened 7 years ago
Closed 7 years ago
layout/base/RestyleTracker.h:262:33: error: 'ProfilerFeature' has not been declared
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | --- | fixed |
People
(Reporter: jbeich, Unassigned)
References
Details
(Keywords: regression)
Attachments
(1 file)
Gecko Profiler is not implemented on many Tier3 platforms (e.g. Linux on non-x86, iOS, Darwin/X11, BSDs, Solaris) but "struct ProfilerFeature" definition is gated on it. In file included from layout/base/nsRefreshDriver.cpp:50: In file included from objdir/dist/include/mozilla/GeckoRestyleManager.h:18: layout/base/RestyleTracker.h:262:33: error: use of undeclared identifier 'ProfilerFeature' if (profiler_feature_active(ProfilerFeature::Restyle)) { ^ 1 error generated. http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/2076/steps/build/logs/stdio (openbsd) http://buildbot.rhaalovely.net/builders/mozilla-central-freebsd-amd64/builds/1181/steps/build/logs/stdio
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
status-firefox55:
--- → affected
status-firefox-esr52:
--- → unaffected
Keywords: regression
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8865053 [details] Bug 1362598 - Always define ProfilerFeature as there's no stub. https://reviewboard.mozilla.org/r/136722/#review140226
Attachment #8865053 -
Flags: review?(mstange) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ae2b60255707 Always define ProfilerFeature as there's no stub. r=mstange
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ae2b60255707
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•