1362882 - Switch from Promise.defer() to new Promise()

Status: RESOLVED FIXED

(Toolkit :: Async Tooling, enhancement)

Description

[Florian Quèze [:florian]]

Much of this change can be done using automated scripts.

Comment 1

[Florian Quèze [:florian]]

Attachment: script-generated patch

This handles only the cases that are 'straightforward', ie. where the output of Promise.defer() is assigned to a local variable that isn't re-used for something else. Restricting to this specific (most common) case lets the script completely remove the variable.

Comment 2

[Florian Quèze [:florian]]

Attachment: hand cleanup

Comment 3

[Florian Quèze [:florian]]

Attachment: promise.defer.js xpcshell script

This is the script I used to generate attachment 8865256 [details] [diff] [review].

Comment 4

[Florian Quèze [:florian]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b08453ff9df93104919bc32adc98af81d2e08b8b looks pretty green.

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8865256 [details] [diff] [review]
script-generated patch

Review of attachment 8865256 [details] [diff] [review]:
-----------------------------------------------------------------

Can I get a diff -w for this patch?

Comment 6

[Florian Quèze [:florian]]

Attachment: diff -w of the script-generated patch

Sure, the diff -w has 725 changed lines instead of 2721 in the full diff.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/c143205c3f20
script-generated patch to switch from Promise.defer() to new Promise() where it's straightforward, rs=Mossop.
https://hg.mozilla.org/mozilla-central/rev/78bda617988b
hand cleanup after applying the previous script-generated patch, r=Mossop.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c143205c3f20
https://hg.mozilla.org/mozilla-central/rev/78bda617988b