Closed Bug 1362890 Opened 7 years ago Closed 7 years ago

Stop using the :not(:target) selector in sync-illustration.svg

Categories

(Firefox :: Theme, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

As part of fixing bug 1358998 we should stop using the :not(:target) selector in:

https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/fxa/sync-illustration.svg
Attached patch patchSplinter Review
Attachment #8865264 - Flags: review?(dao+bmo)
Comment on attachment 8865264 [details] [diff] [review]
patch

It's a bit unfortunate that this repeats #bfcbd3 so often. I guess there's no way to use that color in the SVG by default with optional context-fill?
Attachment #8865264 - Flags: review?(dao+bmo) → review+
Sadly not.
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc9ff81ed453
Stop using the :not(:target) selector in sync-illustration.svg. r=dao
https://hg.mozilla.org/mozilla-central/rev/dc9ff81ed453
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: