Closed
Bug 1363095
Opened 7 years ago
Closed 7 years ago
Remove unused PREF_SKIPDEFAULTBROWSERCHECK define
Categories
(Firefox :: Shell Integration, enhancement)
Firefox
Shell Integration
Tracking
()
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
Details
Attachments
(1 file)
No description provided.| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8865534 [details] Bug 1363095 - Remove unused PREF_SKIPDEFAULTBROWSERCHECK define. https://reviewboard.mozilla.org/r/137158/#review140556 ::: browser/components/shell/nsShellService.h (Diff revision 1) > > #define PREF_CHECKDEFAULTBROWSER "browser.shell.checkDefaultBrowser" > -#define PREF_SKIPDEFAULTBROWSERCHECK "browser.shell.skipDefaultBrowserCheck" > #define PREF_DEFAULTBROWSERCHECKCOUNT "browser.shell.defaultBrowserCheckCount" > > -#define SHELLSERVICE_PROPERTIES "chrome://browser/locale/shellservice.properties" Looks like we're still using this? http://searchfox.org/mozilla-central/source/browser/components/shell/nsWindowsShellService.cpp#691
Attachment #8865534 -
Flags: review?(jmathies) → review-
|
Assignee | |
Comment 3•7 years ago
|
||
Hmm, not sure how I missed this.
|
|
Assignee | |
Updated•7 years ago
|
Summary: Remove unused defines from nsShellService.h → Remove unused PREF_SKIPDEFAULTBROWSERCHECK define
| Comment hidden (mozreview-request) |
|
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8865534 [details] Bug 1363095 - Remove unused PREF_SKIPDEFAULTBROWSERCHECK define. https://reviewboard.mozilla.org/r/137158/#review141298
Attachment #8865534 -
Flags: review?(jmathies) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/13a6ff7f76c8 Remove unused PREF_SKIPDEFAULTBROWSERCHECK define. r=jimm
|
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/13a6ff7f76c8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Comment 8•7 years ago
|
||
I have reproduced this Bug on Nightly 55.0a1 (2017-05-08) on Windows 10, 64 Bit! The bug's fix is now verified on latest Beta 55.0b4 Build ID 20170622104007 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
QA Whiteboard: [bugday-20170621]
You need to log in
before you can comment on or make changes to this bug.
Description
•