Closed
Bug 1363288
Opened 7 years ago
Closed 7 years ago
Add a warning when Console.time(label) is used twice
Categories
(DevTools :: Console, enhancement)
DevTools
Console
Tracking
(firefox55 verified)
VERIFIED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | verified |
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file)
11.31 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
> console.time('a'); a: timer started >console.time('a'); <-- this is ignored but no warning message is shown. a: timer started <-- this is a wrong message. timer 'a' already started. In order to implement this warning message, we need to introduce the check in the DOM Console code.
Assignee | ||
Comment 1•7 years ago
|
||
Probably I have to fix some tests before landing the patch.
Assignee: nobody → amarchesini
Attachment #8865785 -
Flags: review?(bgrinstead)
Comment 2•7 years ago
|
||
Comment on attachment 8865785 [details] [diff] [review] console1.patch Review of attachment 8865785 [details] [diff] [review]: ----------------------------------------------------------------- Looks good for me from the devtools end
Attachment #8865785 -
Flags: review?(bgrinstead) → review+
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d5bbcf94d13f Console.time() prints a warning if used twice with the same label, r=bgrins
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d5bbcf94d13f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 5•7 years ago
|
||
I have reproduced this bug with nightly 55.0a1 (2017-05-09) on Ubuntu 16.04(64 Bit). The bug's fix is now verified on Latest nightly 55.0a1. Build ID : 20170513100302 User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 [testday-20170512]
Comment 6•7 years ago
|
||
I have reproduced this bug with Nightly 55.0a1 (2017-05-09) on Windows 10, 64 bit! The fix is now verified on Latest Nightly Build ID 20170523030206 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0 [bugday-20170524]
Comment 7•7 years ago
|
||
As per comment 5 and 6 making this bug verified now.
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•