Closed
Bug 1363321
Opened 7 years ago
Closed 7 years ago
Reset crash loop counter some time after starting
Categories
(Firefox for Android Graveyard :: General, enhancement)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: JanH, Assigned: JanH)
References
Details
Attachments
(2 files)
At the moment our crash loop counter that turns off session restoring is reset only after successful background-foreground cycle. Since its purpose is to break out of start up crash loops caused by the currently loaded tab, it makes sense to also (or instead?) reset it if we didn't crash within the first minute or so after starting up.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8866453 [details] Bug 1363321 - Part 1 - Always copy crash restore settings to Java on startup. https://reviewboard.mozilla.org/r/138078/#review141296
Attachment #8866453 -
Flags: review?(nchen) → review+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8866454 [details] Bug 1363321 - Part 2 - Reset crash loop counter after a presumably succesful startup. https://reviewboard.mozilla.org/r/138080/#review141306 ::: mobile/android/base/java/org/mozilla/gecko/GeckoApp.java:188 (Diff revision 1) > // after a version upgrade. > private static final int CLEANUP_DEFERRAL_SECONDS = 15; > > + // Length of time in ms during which crashes are classified as startup crashes > + // for crash loop detection purposes. > + private static final int STARTUP_PHASE_DURATION = 30 * 1000; Maybe `STARTUP_PHASE_DURATION_MILLIS` to match other time constants that have units at the end.
Attachment #8866454 -
Flags: review?(nchen) → review+
Comment hidden (mozreview-request) |
Pushed by mozilla@buttercookie.de: https://hg.mozilla.org/integration/autoland/rev/5ce60a1ee7c9 Part 1 - Always copy crash restore settings to Java on startup. r=jchen https://hg.mozilla.org/integration/autoland/rev/5c918b5507a6 Part 2 - Reset crash loop counter after a presumably succesful startup. r=jchen
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5ce60a1ee7c9 https://hg.mozilla.org/mozilla-central/rev/5c918b5507a6
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•