1363356 - PNG files used for UI can be compressed more

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Theme and Visual Design, enhancement, P5)

Description

[Andreas Bovens [:abovens]]

The PNG files inside the Firefox for Android APK can have stronger lossless compression applied than is currently the case.

I unpacked the APK and ran all contained PNG files through ImageOptim (Extreme setting): I managed to shave off 271 KB from the total size of 1,3MB (average of 26% per file). It remains to be seen how big the impact is once the APK is repacked again, but as every byte counts on slow connections, it would be good to look into this.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Hey Tim, this looks worthwhile. Could you assign someone?

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thanks snorp.

Beside one-off compression work for the PNGs in the tree, I would love to figure out whether or not we can put something in task cluster to guard it. I was told there aren't anything yet in the tree.

:catlee, :RyanVM say you have some previous experience with this; I am on your timezone this week so I would love to talk to you on that.

For the test itself it probably doesn't make sense to actually compress the files; I am thinking about creating a while list and check the size of the PNG files against it.

Comment 3

[Chris AtLee [:catlee]]

See also bug 1234008.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I spin-off test/lint work to bug 1363489. Let's use this bug to complete an one-off PNG compression related to Fennec.

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

Previously bug 1150973, bug 1150974, bug 1193580

Comment 6

[Chris AtLee [:catlee]]

(In reply to Andreas Bovens from comment #0)
> The PNG files inside the Firefox for Android APK can have stronger lossless
> compression applied than is currently the case.
> 
> I unpacked the APK and ran all contained PNG files through ImageOptim
> (Extreme setting): I managed to shave off 271 KB from the total size of
> 1,3MB (average of 26% per file). It remains to be seen how big the impact is
> once the APK is repacked again, but as every byte counts on slow
> connections, it would be good to look into this.

Do you know how well ImageOptim does compared to zopflipng?

Comment 7

[Andreas Bovens [:abovens]]

> Do you know how well ImageOptim does compared to zopflipng?

ImageOptim includes Zopfli as one of its compression options.

Comment 8

[Andreas Bovens [:abovens]]

What's the status on this issue? It would be nice if we can move forward with it, as it will partially offset the file size increase that comes with Stylo.

We should also remove unused images from the APK. There are a number of unnecessary bits in the APK (old icons, Google+ icons, etc.) that can be removed. (on desktop, this is tracked as bug 1316187)

Comment 9

[Wesly Huang (EPM)]

Maybe snorp can comment about image files in omni.ja?

For the rest they might be good candidates for Nightly 60 cycle, I'll bring it to 60.1 planning next Tuesday. Per the last mail conversation:

1. Previously there's a bug https://bugzilla.mozilla.org/show_bug.cgi?id=1229269 for shink resource in dependency, need to check further.
2. For the old icon, it's used by default bookmarks I'm not sure if we want to remove firstrun_tabqueue_off and bookmarkdefaults_favicon_restricted_webmaker.
3. For image files in omni.ja, I think snorp may know better. I guess some files in it are used by browser.js or gecko or even Desktop.

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

Clearing NI. No bandwidth to really look at this right now.

Comment 11

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 12

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.