1363672 - [DateTimePicker] Add step support to date picker

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, enhancement, P1)

Description

[Scott Wu [:scottwu]]

Support the step property for date picker. Dates should be disabled if they are off-step, as shown in the UX spec: https://mozilla.invisionapp.com/share/237UTNHS8#/screens/171579745

Comment 1

[Scott Wu [:scottwu]]

Attachment: Bug 1363672 - Add step support to date picker.

Review commit: https://reviewboard.mozilla.org/r/138334/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138334/

Comment 2

[Scott Wu [:scottwu]]

Implemented step for the calendar view. Step feature for month and year spinners has been de-scoped.

In this patch, the `getDays` function in `datekeeper.js` has been re-arranged, and "selection" state would not be applied if the date is either out-of-range or off-step.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8866709 [details]
Bug 1363672 - Add step support to date picker.

https://reviewboard.mozilla.org/r/138334/#review143182

This looks great! Thanks!

Comment 4

[Scott Wu [:scottwu]]

Thanks Mike, I've since found a few issues with how min/max/value are handled in this patch, so I'll delay landing this patch for now.

Comment 5

[Scott Wu [:scottwu]]

Comment on attachment 8866709 [details]
Bug 1363672 - Add step support to date picker.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138334/diff/1-2/

Comment 6

[Scott Wu [:scottwu]]

Updated the patch to use `getStep` and `getStepBase` which are used by input fields to calculate steps. This simplifies things because the picker wouldn't need to do the same calculation when input field also did. Aside from that, nothing is changed. I think it's safe to check this in.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7afd5fee9f2
Add step support to date picker. r=mconley

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f7afd5fee9f2