1363840 - Detach the back and forward buttons from the location bar

Status: VERIFIED FIXED

(Firefox :: Theme, enhancement, P1)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1363840 - Detach the back and forward buttons from the location bar.

Review commit: https://reviewboard.mozilla.org/r/138104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138104/

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8866475 [details]
Bug 1363840 - Detach the back and forward buttons from the location bar.

https://reviewboard.mozilla.org/r/138104/#review141320

At least in OSX we can make the forward button look a bit nicer by disabling shorlander's recent changes: https://searchfox.org/mozilla-central/rev/d66b9f27d5630a90b2fce4d70d4e9050f43df9b4/browser/themes/osx/browser.css#579

And in compact theme we should disable the forward button and urlbar borders:
https://searchfox.org/mozilla-central/source/browser/themes/shared/compacttheme.inc.css#209
https://searchfox.org/mozilla-central/source/browser/themes/shared/compacttheme.inc.css#262

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8866475 [details]
Bug 1363840 - Detach the back and forward buttons from the location bar.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138104/diff/1-2/

Comment 4

[Dão Gottwald [:dao]]

Compact themes still don't seem perfect with MOZ_PHOTON_THEME, but I don't think we need to spend more time on this now since this stuff will change drastically anyway.

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 8866475 [details]
Bug 1363840 - Detach the back and forward buttons from the location bar.

https://reviewboard.mozilla.org/r/138104/#review141334

I agree, those were just the most visible things. Want to avoid followup discussions :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a46c4ea1cf30
Detach the back and forward buttons from the location bar. r=johannh

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/83478ac51418
followup: fix browser_formless_submit_chrome.js on CLOSED TREE

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a46c4ea1cf30
https://hg.mozilla.org/mozilla-central/rev/83478ac51418

Comment 9

[Stephen]

Hi ,
cannot change the position of back/forward button.
After this bug landed it should have been possible right?

Comment 10

[Dão Gottwald [:dao]]

(In reply to jaruvova from comment #9)
> Hi ,
> cannot change the position of back/forward button.
> After this bug landed it should have been possible right?

This was the first step. Bug 1363485 will open up the possibility to move these elements, at least indirectly by moving other elements between these ones.

Comment 11

[Stephen]

(In reply to Dão Gottwald [::dao] from comment #10)
> (In reply to jaruvova from comment #9)
> > Hi ,
> > cannot change the position of back/forward button.
> > After this bug landed it should have been possible right?
> 
> This was the first step. Bug 1363485 will open up the possibility to move
> these elements, at least indirectly by moving other elements between these
> ones.

oh okay thanks

Comment 12

[Sayed [:LiquidO2]]

I can see this implemented in Latest Nightly 55.0a1 on Manjaro Linux 17, 64bit

Build ID 	20170513100302
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

[testday-20170513]

Comment 13

[Johann Hofmann [:johannh]]

Mozscreenshots results:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=838652a84b76c273e084d0705f3f4f3be89520a8&newProject=mozilla-central&newRev=0259418f19ab804b126730ef1d5d03006d6aad52

Looks all good to me.

Comment 14

[drudigger]

This update should have never went live without the ability to put it back where it was, this is horrible now, thanks for ruining my browser experience by adding an unnecessary button in place of the old reload location to copy and email links which you can do easily anyway by simply right clicking and copy for the normal user. Or simple keyboard ctrl+c, this fix provides nothing but annoyance without the ability to put it back where it was, now its just **** me off from the browser ive been using since firebird, moving my reload button to the left side makes me feel like i was put back in the 90s forced to accept **** choices by devs, until this is changed im done with nightly and firefox in general, horrible choice to implement this without a remedy for users.

Comment 15

[Alexandre Folle de Menezes]

I hate to spam here, but I have also stopped used nigthly because of this unfortunate change (and forcing me to use the horrible native Pocket instead of the classic plugin).

Comment 16

[drudigger]

you can flag me all you want, doesn't change the fact that the majority of users wont like this change.

Comment 17

[ovidiu boca[:Ovidiu]]

I tested this issue on Windows 7, Mac Os X 10.10 and Ubuntu 16.04 with FF Nightly 55.0a1(2017-06-11) and I can confirm the fix.