Closed Bug 1363900 Opened 7 years ago Closed 6 years ago

Turn RTP header extension ID mismatch into error

Categories

(Core :: WebRTC: Signaling, enhancement, P3)

Product:
Core
Component:
WebRTC: Signaling
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: drno, Assigned: drno)

References

Details

Attachments

(1 file)

Bug 1363900: re-enable extmap ID remapping error.
59 bytes, text/x-review-board-request
bwc
: review+
Details 
In bug 1355010 we temporarily reduced the error when the answerer changes RTP header extension IDs into a warning.

Once Cisco Spark no longer changes ID's in it's answerer we should turn it back into an error.
Rank: 21
Target Milestone: --- → mozilla57
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
The bug number in the description is wrong: It was not bug 1355010 but bug 1361206 where we turned of the RTP header extension ID matching check
Looks like we can turn this back into an error... because Cisco Spark no longer negotiates any header extensions at all?!
Turns out Cisco Spark is stripping the extmap from their SDP. So we can put the error back in.
Attachment #8954659 - Flags: review?(docfaraday)
Comment on attachment 8954659 [details]
Bug 1363900: re-enable extmap ID remapping error.

https://reviewboard.mozilla.org/r/223758/#review230236
Attachment #8954659 - Flags: review?(docfaraday) → review+
I guess this will have to wait until the soft freezes is lifted and 61 is going...
Assignee: nobody → drno
Flags: needinfo?(drno)
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/6bc7318ca790
re-enable extmap ID remapping error. r=bwc
https://hg.mozilla.org/mozilla-central/rev/6bc7318ca790
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: mozilla57 → mozilla61
Flags: needinfo?(drno)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: