136406 - dnsservice asserts do not match return values

Status: VERIFIED WONTFIX

(Core :: Networking, enhancement)

Description

[timeless]

950 gordon 1.80 NS_ASSERTION(mDNSServiceLock == nsnull, "nsDNSService 
not shut down");
951 if (mDNSServiceLock) return NS_ERROR_ALREADY_INITIALIZED;
The return is already initialized; the assertion should be too.

986 gordon 1.36 // create DNS thread
987 gordon 1.45 NS_ASSERTION(mThread == nsnull, "nsDNSService not shut down");
I'm not sure what the assertion should be,
but I'm pretty sure that it shouldn't be what it is.

Comment 1

[gordon]

These assertions fire only if the DNS service was previously initialized and not
shutdown properly, so although the assertions don't match the returned error
word for word, I don't think they're wrong.

Marking WONTFIX, but I'm happy to entertain counter proposals.

Comment 2

[benc]

VERIFIED/wontfix