Closed
Bug 1364169
Opened 7 years ago
Closed 7 years ago
ANGLE contexts request robustness but do not get it
Categories
(Core :: Graphics: CanvasWebGL, enhancement, P1)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: svargas, Assigned: svargas, Mentored)
References
Details
(Whiteboard: gfx-noted)
Attachments
(1 file, 2 obsolete files)
1.23 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8866891 -
Flags: review?(jgilbert)
Comment 2•7 years ago
|
||
Comment on attachment 8866891 [details] [diff] [review] 0001-Bug-1364169-on-ANGLE-context-creation-asks-for-robus.patch Review of attachment 8866891 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/angle/src/libANGLE/Context.cpp @@ +166,5 @@ > + { > + attrib = EGL_NO_RESET_NOTIFICATION; > + } > + > + return attrib; We actually still need the switch, because we need to convert between the EGL_ enums here, and the GL_ enums this function is supposed to return. (and the EGL_ and GL_ values differ)
Attachment #8866891 -
Flags: review?(jgilbert) → review-
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8866891 -
Attachment is obsolete: true
Attachment #8866923 -
Flags: review?(jgilbert)
Comment 4•7 years ago
|
||
Comment on attachment 8866923 [details] [diff] [review] 0001-Bug-1364169-on-ANGLE-context-creation-asks-for-robus.patch Review of attachment 8866923 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/angle/src/libANGLE/Context.cpp @@ +157,4 @@ > > GLenum GetResetStrategy(const egl::AttributeMap &attribs) > { > + EGLAttrib attrib = attribs.get(EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR, 0); These are tabs for some reason!
Attachment #8866923 -
Flags: review?(jgilbert) → review-
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8866923 -
Attachment is obsolete: true
Attachment #8866928 -
Flags: review?(jgilbert)
Updated•7 years ago
|
Attachment #8866928 -
Flags: review?(jgilbert) → review+
Updated•7 years ago
|
Keywords: checkin-needed
Updated•7 years ago
|
Assignee: nobody → svargas
Priority: -- → P1
Whiteboard: gfx-noted
Comment 6•7 years ago
|
||
For future reference, please try to use commit messages that summarize what the patch is actually doing rather than restating the problem being fixed. Thanks!
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a7dc86b21aa5 On ANGLE context creation asks for robustness but does not get it. r=jgilbert
Keywords: checkin-needed
This caused failures like https://treeherder.mozilla.org/logviewer.html#?job_id=98507577&repo=mozilla-inbound on Windows webgl mochitests Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/cb8a328af904
Flags: needinfo?(svargas)
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/74b2d6cfaee3 on ANGLE context creation asks for robustness but does not get it - r=jgilbert
Updated•7 years ago
|
Depends on: 1365067
Summary: on ANGLE context creation asks for robustness but does not get it → ANGLE contexts request robustness but do not get it
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/74b2d6cfaee3
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•