Closed
Bug 1364592
Opened 7 years ago
Closed 7 years ago
Enable asserts in moz.build for ANGLE
Categories
(Core :: Graphics: CanvasWebGL, enhancement, P1)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: svargas, Assigned: svargas, Mentored)
References
Details
(Whiteboard: gfx-noted)
Attachments
(1 file, 2 obsolete files)
2.39 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8867393 -
Flags: review?(jgilbert)
Comment 2•7 years ago
|
||
Comment on attachment 8867393 [details] [diff] [review] 0001-Bug-1364592-Enable-asserts-in-moz.build-for-ANGLE-r-.patch Review of attachment 8867393 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/angle/moz.build @@ +147,5 @@ > DEFINES['_SECURE_SCL'] = 0 > > DEFINES['ANGLE_ENABLE_D3D9'] = True > + > +DEFINES['ANGLE_ASSERTS_ON'] = True This unconditionally enables asserts, and will probably cause a build to fail because of macro redefinition. Remove this line. @@ +148,5 @@ > > DEFINES['ANGLE_ENABLE_D3D9'] = True > + > +DEFINES['ANGLE_ASSERTS_ON'] = True > +DEFINES['NOASSERT_UNIMPLEMENTED'] = False Leave a comment: # Enable asserts for UNIMPLEMENTED().
Attachment #8867393 -
Flags: review?(jgilbert) → review-
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → svargas
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8867393 -
Attachment is obsolete: true
Attachment #8867401 -
Flags: review?(jgilbert)
Updated•7 years ago
|
Attachment #8867401 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 4•7 years ago
|
||
The previous patch file didn't actually override the #define NOASSERT_UNIMPLEMENTED in angle/src/debug.h. This patch updates all four moz.builds with the correct value for NOASSERT_UNIMPLEMENTED. This patch is related to: https://bugzilla.mozilla.org/show_bug.cgi?id=1364169#c8 This patch should cause the if (mRobustAccess) { UNIMPLEMENTED(); } to trigger an assert preventing the aforementioned bug from occurring. (The next step would be to disable robust access if on ANGLE to prevent this assert from occurring).
Attachment #8867401 -
Attachment is obsolete: true
Attachment #8867890 -
Flags: review?(jgilbert)
Updated•7 years ago
|
Attachment #8867890 -
Flags: review?(jgilbert) → review+
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7c57d9481b54 Enable asserts in moz.build for ANGLE - r=jgilbert
Updated•7 years ago
|
Priority: -- → P1
Whiteboard: gfx-noted
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7c57d9481b54
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•