1364661 - Remove _fillTrailingGap

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P1)

Description

[Dão Gottwald [:dao]]

This was working around some old XUL layout weirdness, but nowadays this uses the same scroll frame implementation as HTML and as I understand it, tabStrip.scrollPosition + tabStrip.scrollClientSize > tabStrip.scrollSize cannot be true.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1364661 - Remove _fillTrailingGap.

This was working around some old XUL layout weirdness, but nowadays this uses the same scroll frame implementation as HTML and tabStrip.scrollPosition + tabStrip.scrollClientSize > tabStrip.scrollSize cannot be true.

Review commit: https://reviewboard.mozilla.org/r/139010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139010/

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8867452 [details]
Bug 1364661 - Remove _fillTrailingGap.

https://reviewboard.mozilla.org/r/139010/#review142294

::: browser/base/content/test/general/browser_tabopen_reflows.js
(Diff revision 1)
> -  // SessionStore.getWindowDimensions()
> -  "ssi_getWindowDimension@resource:///modules/sessionstore/SessionStore.jsm|" +
> -    "ssi_updateWindowFeatures/<@resource:///modules/sessionstore/SessionStore.jsm|" +
> -    "ssi_updateWindowFeatures@resource:///modules/sessionstore/SessionStore.jsm|" +
> -    "ssi_collectWindowData@resource:///modules/sessionstore/SessionStore.jsm|",
> -

FYI, bug 1358809 removed this reflow.

::: devtools/client/responsive.html/docs/browser-swap.md
(Diff revision 1)
>        * Emit `EndSwapDocShells`
>      * `gBrowser.mTabProgressListener`
>      * `filter.addProgressListener`
>      * `ourBrowser.webProgress.addProgressListener`
>    * `gBrowser._endRemoveTab`
> -    * `gBrowser.tabContainer._fillTrailingGap`

Not really sure what this file is...

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8867452 [details]
Bug 1364661 - Remove _fillTrailingGap.

https://reviewboard.mozilla.org/r/139010/#review142316

Nice! :-)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55ec58fcd793
Remove _fillTrailingGap. r=florian

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/55ec58fcd793