1364708 - Update test code to reflect recommended way to read clipboard from the background page

Status: RESOLVED WONTFIX

(WebExtensions :: General, enhancement, P5)

Description

[Tomislav Jovanovic :zombie]

See Andy's example https://github.com/andymckay/clippy

Comment 1

[Tomislav Jovanovic :zombie]

Will investigate what's the difference between this and our tests.

Comment 2

[Tomislav Jovanovic :zombie]

So, it turns out a <textarea>, contentEditable and .value DOM property don't mix very well, and .textContent should be used instead.  This code works for me (with extensions.remote=true).

    let area = document.createElement("textarea");
    area.contentEditable = true;
    document.body.appendChild(area);

    function paste() {
      area.textContent = '';
      area.select();
      console.log('Pre-paste: ' + area.value);
      console.log(document.execCommand("paste"));
      console.log('Post-paste: ' + area.value);
    }

    function copy(text) {
      area.textContent = text;
      area.select();
      console.log('Pre-copy: ' + area.value);
      console.log(document.execCommand("copy"));
      console.log('Post-copy: ' + area.value);
    }

This bug could be about updating our test to use the same (recommended) code, but that's likely a lower priority.

Comment 3

[Andy McKay]

I can't get copy to work by using a background page with remote set to true, in Nightly on Windows.

Comment 4

[Andy McKay]

I'm an idiot, I was setting the value in the wrong browser. Ignore my last comment.

Comment 5

[Geoffrey De Belie (Smile4ever)]

This is still needed. Can probably use the Clipboard Web API for the text part.

Comment 6

[Rob Wu [:robwu]]

The existing tests use .value, which has been working for the past few years.

Setting .textContent would be equivalent to setting .defaultValue. That is not wrong, but it is not necessary either.