1364845 - stylo: add support for a "re-run selector matching on children only" restyle hint

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Cameron McCormack (:heycam)]

This is something that Gecko doesn't do (though could), but I had written down in my notes, and wasn't too hard.

Comment 1

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7ddf9a3df019bfa707b8b6804bfdce3f2a025fd

Comment 2

[Cameron McCormack (:heycam)]

https://github.com/servo/servo/pull/16906

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Bug 1364845 - stylo: Adjust test expectations.

Review commit: https://reviewboard.mozilla.org/r/141018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141018/

Comment 4

[Cameron McCormack (:heycam)]

Actually I'm not sure if these adjustments are needed due to this bug, or bug 1289868, since I've been testing them together.

Filed bug 1366206 for the MathML one.  399384-1.html is a ::first-line test, so don't put too much stock in it passing now.

For the test_transitions_and_reframes.html failures, it's this:

TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_and_reframes.html | margin of child of element b2 (classes: t m o) ::before pseudo-element - got "100px", expected "25px"
TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_and_reframes.html | margin of child of element a2 (classes: t m o) ::after pseudo-element - got "100px", expected "25px"
TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_and_reframes.html | margin of child of element b2 (classes: m o t) ::before pseudo-element - got "100px", expected "25px"
TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_and_reframes.html | margin of child of element a2 (classes: m o t) ::after pseudo-element - got "100px", expected "25px" 

Given the current implementation state of transitions and pseudo-elements, do you think it's not unexpected that this could start failing?  If you think I should look into this, I can, though I'd rather land these patches first since it's taken me a while to get them to the point of being landable and don't want to do any more rebasing. :-)

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8869371 [details]
Bug 1364845 - stylo: Adjust test expectations.

https://reviewboard.mozilla.org/r/141018/#review144592

I think the transitions in pseudo-element tests are worth looking into, since when I was writing bug 1331047 the failures revealed some legit bugs.

That being said, I think it's fine to investigate them as a followup, so r=me with a followup bug referenced from the expectations file.

Comment 6

[Cameron McCormack (:heycam)]

Comment on attachment 8869371 [details]
Bug 1364845 - stylo: Adjust test expectations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141018/diff/1-2/

Comment 7

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=73e544fdd4693b0f7b54b3a9d9392b278f38bee3

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36678242b5a6
stylo: Adjust test expectations. r=emilio

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/36678242b5a6