Closed Bug 1364865 Opened 7 years ago Closed 7 years ago

process_util.h should use _POSIX_PATH_MAX instead of NAME_MAX

Categories

(Core :: IPC, defect)

45 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: petr.sumbera, Assigned: petr.sumbera)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; SunOS i86pc; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20170420232850

Steps to reproduce:

Not every POSIX system has to define NAME_MAX. See for example:

https://sourceforge.net/p/materm/bugs/121/

Therefore ipc/chromium/src/base/process_util.h should be modified to use for example _POSIX_PATH_MAX (which seems to me appropriate as on Windows it uses MAX_PATH).
Attached patch Bug1364865.patchSplinter Review
Attachment #8867657 - Flags: review?(wmccloskey)
Component: Untriaged → IPC
Product: Firefox → Core
Attachment #8867657 - Flags: review?(wmccloskey) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3f8917bd944
process_util.h should use _POSIX_PATH_MAX instead of NAME_MAX. r=billm
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b3f8917bd944
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee: nobody → petr.sumbera
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: