Closed
Bug 1364911
Opened 7 years ago
Closed 7 years ago
Wait for the history subview to be populated before opening it
Categories
(Firefox :: Toolbars and Customization, enhancement)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: Paolo, Assigned: Paolo)
References
Details
Attachments
(1 file)
We should wait for the history subview to be populated before opening it, so that we can transition to its final height directly in bug 1009116.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
The Sync view seems to be the only other one that does asynchronous operations, but I believe they involve the network and they're enqueued to previous operations, so we shouldn't wait on them.
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8867719 [details] Bug 1364911 - Wait for the history subview to be populated before opening it. https://reviewboard.mozilla.org/r/139298/#review142562
Attachment #8867719 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by paolo.mozmail@amadzone.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/aed8ff339114 Wait for the history subview to be populated before opening it. r=Gijs
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/aed8ff339114
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 6•7 years ago
|
||
after this landed and got merged later we got a lot of failures which are perma failures (https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&bugfiler&noautoclassify&filter-searchStr=OS%20X%2010.10%20debug%20Mochitest%20e10s%20Mochitest%20e10s%20Browser%20Chrome%20M-e10s(bc7)&fromchange=c8840a3a2c3b99270e26709c9549496fa206b8eb&selectedJob=99383604) like https://treeherder.mozilla.org/logviewer.html#?job_id=99383604&repo=mozilla-inbound and also on autoland https://treeherder.mozilla.org/logviewer.html#?job_id=99328914&repo=autoland so backing this out to fix the leak
Status: RESOLVED → REOPENED
Flags: needinfo?(paolo.mozmail)
Resolution: FIXED → ---
Backout by cbook@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/5e81f9511634 Backed out changeset aed8ff339114 for memory leaks and making Bug/test failure bug 1340425 perma fail
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9296a420939013656208bf607d0484905bddf6c4
Flags: needinfo?(paolo.mozmail)
Comment 10•7 years ago
|
||
Pushed by paolo.mozmail@amadzone.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/363d0da6b3bc Wait for the history subview to be populated before opening it. r=Gijs
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/363d0da6b3bc
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•