Closed
Bug 1364925
Opened 7 years ago
Closed 7 years ago
navigator.sendBeacon should not force application/octet-stream as content-type for ArrayBuffer
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(2 files, 2 obsolete files)
|
1.02 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
5.37 KB,
patch
|
annevk
:
review+
|
Details | Diff | Splinter Review |
This is a follow up of 1329298 comment 11.
|
Assignee | |
Comment 1•7 years ago
|
||
See https://bugzilla.mozilla.org/show_bug.cgi?id=1329298#c11
|
|
Assignee | |
Comment 2•7 years ago
|
||
Per spec, we should force any special content-type if the body extractor returns null.
Assignee: nobody → amarchesini
Attachment #8867750 -
Flags: review?(bugs)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8867750 [details] [diff] [review] beacon.patch We really need wpt tests for this, but I have no idea how to write such. Please ask jgraham or someone.
Attachment #8867750 -
Flags: review?(bugs) → review+
|
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8867750 [details] [diff] [review] beacon.patch Wait, so what content type is used after this patch?
|
|
||
Comment 5•7 years ago
|
||
I guess nothing, which is per Fetch spec.
|
|
Assignee | |
Comment 6•7 years ago
|
||
Attachment #8868299 -
Flags: review?(james)
|
|
Assignee | |
Comment 7•7 years ago
|
||
Attachment #8868299 -
Attachment is obsolete: true
Attachment #8868299 -
Flags: review?(james)
Attachment #8868411 -
Flags: review?(annevk)
|
|
Assignee | |
Comment 8•7 years ago
|
||
step_timeout instead of setTimeout
Attachment #8868411 -
Attachment is obsolete: true
Attachment #8868411 -
Flags: review?(annevk)
Attachment #8868444 -
Flags: review?(annevk)
|
||
Comment 9•7 years ago
|
||
Comment on attachment 8868444 [details] [diff] [review] beacon2.patch Review of attachment 8868444 [details] [diff] [review]: ----------------------------------------------------------------- Looks reasonable.
Attachment #8868444 -
Flags: review?(annevk) → review+
|
||
Comment 10•7 years ago
|
||
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2e7b01803f79 navigator.sendBeacon should not force application/octet-stream as content-type for ArrayBuffer, r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/862bbeb666a0 WPT for sendBeacon and content-type header, r=annevk
|
||
Comment 11•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2e7b01803f79 https://hg.mozilla.org/mozilla-central/rev/862bbeb666a0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•