1364999 - The reload icon looks off-center

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[Markus Stange [:mstange]]

Attachment: screenshot

See the screenshot. It looks to me like the refresh icon is a little too far to the right.

Comment 1

[Johann Hofmann [:johannh]]

So it seems that the icon itself is a little offset (navigate to chrome://browser/skin/reload.svg). I think it's not worth fixing this in Nightly until we do bug 1355455.

Thanks :)

Comment 2

[Dão Gottwald [:dao]]

Better keep this open to make sure we actually end up fixing this.

Comment 3

[Dão Gottwald [:dao]]

I think the icon is still leaning a bit to the right. Markus, can you confirm?

Stephen, what do you think?

Comment 4

[Dão Gottwald [:dao]]

Alas, if we want to do anything about this, we'll have to change not only reload.svg but also reload-to-stop.svg and stop-to-reload.svg. Not sure if UX uses tools to make that easy.

Comment 5

[Markus Stange [:mstange]]

Slightly, yes. It's less noticeable now, especially because the toolbar button no longer has a border on hover.

Comment 6

[Stephen Horlander [:shorlander]]

The new icon isn't as visually off-center.

Checking with Amy and Eric on how hard it is to move it 1px to the left :)

Comment 7

[Dão Gottwald [:dao]]

(In reply to Stephen Horlander [:shorlander] from comment #6)
> The new icon isn't as visually off-center.
> 
> Checking with Amy and Eric on how hard it is to move it 1px to the left :)

I think 1px is already too and makes it look unbalanced again. Maybe the arrow should become shorter.

Comment 8

[Eric Pang [:epang] UX]

(In reply to Dão Gottwald [::dao] from comment #7)
> (In reply to Stephen Horlander [:shorlander] from comment #6)
> > The new icon isn't as visually off-center.
> > 
> > Checking with Amy and Eric on how hard it is to move it 1px to the left :)
> 
> I think 1px is already too and makes it look unbalanced again. Maybe the
> arrow should become shorter.

Stephen, is there an update on what we want to do here based on Dão's comment?

Jared, is moving the icon 1px to the left something we can do in code or do I need to update the svg-sprite?

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Eric, do you think 1px might be too much (as Dao says in comment 7)?

If we do this we would want to make the change in the SVG-sprite as well as the static icon. Also, would the stop button might need to shift too since they should be in the same position?

Comment 10

[Dão Gottwald [:dao]]

I'm moving this to photon-animation since photon-visual folks aren't equipped to to deal with the SVG sprite.

Comment 11

[Eric Pang [:epang] UX]

Looking at this in more detail I don't think it's worth the effort. Moving the icon by a pixel will cause the same problem as Dao mentioned in comment 7.  With the updated icon, visually it looks pretty centered anyway.

Comment 12

[Adolfo Jayme]

To me, this is a textbook example of bikeshedding.

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

Closing per comment #11.