1365101 - Convert NS_GetCurrentThread uses in netwerk/

Status: RESOLVED FIXED

(Core :: Networking, enhancement)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1365096#c0.

This bug covers all uses in netwerk/.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

Just to give some context for this patch, here is the description from bug 1365096:

> This is a meta bug to cover the conversion:
> 
> 1. of NS_GetCurrentThread or NS_GetMainThread to GetCurrentThreadEventTarget or
> GetMainThreadEventTarget.
> 2. of thread equality checks to event target IsOnCurrentThread checks.
> 
> This will make things easier for the Quantum DOM project, since it will hide
> the fact that there can be multiple "main" threads that share a single main
> event loop.

The definitions of GetCurrentThreadEventTarget and nsISerialEventTarget can be found in bug 1361164.

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8875510 [details] [diff] [review]
patch

Review of attachment 8875510 [details] [diff] [review]:
-----------------------------------------------------------------

So, this depends on https://bugzilla.mozilla.org/attachment.cgi?id=8870204&action=diff right?  Would be good to list the bug# in the depends-on list.

LGTM, but I didn't check if there are more places to convert and also didn't much hunt for leaks/use-after-free (but I don't expect any from the nature of the api).

::: netwerk/base/nsInputStreamPump.cpp
@@ +132,5 @@
>          // Ensure OnStateStop is called on the main thread.
>          if (mState == STATE_STOP) {
>              nsCOMPtr<nsIEventTarget> mainThread = mLabeledMainThreadTarget
>                  ? mLabeledMainThreadTarget
> +                : do_AddRef(GetMainThreadEventTarget());

is the do_AddRef really necessary?  GetMainThreadEventTarget() returns plain nsIEventTarget* (surprisingly..) and here we assign to comptr.  So I don't see a need.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43fcf7ddd6ba
Convert NS_GetCurrentThread uses in netwerk/ (r=meyhemer)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/43fcf7ddd6ba