1365126 - Remove GeckoInterface.createShortcut

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Move shortcut creation to static methods in GeckoApplication (v1)

Move shortcut creation code in GeckoApp to GeckoApplication, and make
the methods static so that we can call them without a GeckoInterface
instance. This lets us remove GeckoInterface.createShortcut.

Comment 2

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 8868170 [details] [diff] [review]
Move shortcut creation to static methods in GeckoApplication (v1)

Review of attachment 8868170 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good with a couple of nits.

::: mobile/android/base/java/org/mozilla/gecko/GeckoApplication.java
@@ +445,5 @@
> +                  }
> +              });
> +    }
> +
> +    /* protected */ static void createShortcutWithIcon(final String aTitle, final String aURI,

Did you mean /* package */ here?

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/ActivityUtils.java
@@ +61,5 @@
>  
>      /**
>       * Finish this activity and launch the default home screen activity.
>       */
> +    public static void goToHomeScreen(Context activity) {

Rename activity to context.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f5485d306e1
Move shortcut creation to static methods in GeckoApplication; r=droeh

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6f5485d306e1