1365150 - profileStorage.get should return null instead of throwing, and .add should return the newly created guid.

Status: RESOLVED FIXED

(Toolkit :: Form Manager, enhancement)

Description

[Mark Hammond [:markh] [:mhammond]]

We'd like .get() to return null on an unknown GUID so we don't need to introspect and exception to determine if it really just means "no record found".

We'd like .add() to return the GUID that was just created to make testing easier.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1365150 - profile.get returns null instead of throwing, .add returns the new GUID.

Review commit: https://reviewboard.mozilla.org/r/139518/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139518/

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8867978 [details]
Bug 1365150 - profile.get returns null instead of throwing, .add returns the new GUID.

https://reviewboard.mozilla.org/r/139518/#review142864

Looks good. Thanks.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8867978 [details]
Bug 1365150 - profile.get returns null instead of throwing, .add returns the new GUID.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/139518/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1798333664b
profile.get returns null instead of throwing, .add returns the new GUID. r=lchang

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d1798333664b