1365273 - Remove about:sync-tabs

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P1)

Description

[Edouard Oger [:eoger]]

We already have a better UI for Synced Tabs (in the hamburger menu and in the sidebar), and this page hasn't been maintained for a while now. Let's kill this.

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1365273 - Remove about:sync-tabs.

Review commit: https://reviewboard.mozilla.org/r/140212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140212/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8868621 [details]
Bug 1365273 - Remove about:sync-tabs.

https://reviewboard.mozilla.org/r/140212/#review143708

Awesome

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Removal of a feature - about:sync-tabs is being removed.
[Affects Firefox for Android]: No
[Suggested wording]: about:sync-tabs has been removed.
[Links (documentation, blog post, etc)]:

It's questionable if this is worth a relnote, as about:sync-tabs wasn't exposed in the UI. However, it's possible some people were using it and may be surprised to find it gone.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8d0fdf79562
Remove about:sync-tabs. r=markh

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for build bustage: Unused pattern 'sync/**' in browser/base/content/moz.build and unreferenced files detected by browser_all_files_referenced.js:

https://hg.mozilla.org/integration/autoland/rev/0f1ea61951fde4e117d6fb099863a64e78997ef8

Push with bustage & failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b8d0fdf7956242f5d82e43e8ef35b6e3b9fa95a3&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Bustage log: https://treeherder.mozilla.org/logviewer.html#?job_id=100144491&repo=autoland
> TEST-UNEXPECTED-FAIL | /home/worker/workspace/build/src/config/tests/test_mozbuild_reading.py | TestMozbuildReading.test_orphan_file_patterns, line 105: The pattern 'sync/**' in a Files() entry in '/home/worker/workspace/build/src/browser/base/content/moz.build' corresponds to no files in the tree. 

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=100155623&repo=autoland

09:51:18     INFO - TEST-START | browser/base/content/test/static/browser_all_files_referenced.js
09:51:26     INFO - TEST-INFO | started process screenshot
09:51:26     INFO - TEST-INFO | screenshot: exit 0
09:51:26     INFO - Buffered messages logged at 09:51:18
09:51:26     INFO - Entering test bound checkAllTheFiles
09:51:26     INFO - Buffered messages finished
09:51:26     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 3, expected 0
09:51:26     INFO - Stack trace:
09:51:26     INFO - chrome://mochikit/content/browser-test.js:test_is:928
09:51:26     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:624
09:51:26     INFO - Not taking screenshot here: see the one that was previously logged
09:51:26     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://browser/skin/sync-16.png - 
09:51:26     INFO - Stack trace:
09:51:26     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:626
09:51:26     INFO - Not taking screenshot here: see the one that was previously logged
09:51:26     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://browser/skin/sync-32.png - 
09:51:26     INFO - Stack trace:
09:51:26     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:626
09:51:26     INFO - Not taking screenshot here: see the one that was previously logged
09:51:26     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://browser/skin/sync-bg.png -

Comment 6

[Edouard Oger [:eoger]]

Comment on attachment 8868621 [details]
Bug 1365273 - Remove about:sync-tabs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/140212/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c73ad4f4e8bb
Remove about:sync-tabs. r=markh

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c73ad4f4e8bb

Comment 9

[Sayed [:LiquidO2]]

I can verify that "about:sync-tabs" page is no longer available in latest Nightly 55.0a1 on Deepin 15.4, 64bit

Build ID 	20170524100215
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170524]

Comment 10

[Julien Cristau [:jcristau]]

This doesn't feel worth a release note.

Comment 11

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 55.0a1 (2017-05-16) on Windows 7, 64 Bit!

This bug's fix is verified with latest Beta!

Build ID   :    20170803103124
User Agent :  	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0