1365291 - Make sure 'this' is captured on dispatch to STS thread in AddRIDExtension_m and AddRIDFilter_m in MediaPipeline

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Michael Froman [:mjf]]

These were seen in a drive-by review on Bug 1358224, along with a potential to remove an unnecessary refcnt in MediaPipeline::GetMediaPipelineForTrack.  These are easy fixes.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1365291 - capture 'this' with RefPtr on dispatch to STS thread.

- Avoid any potential for this going away from underneath the dispatch
to STS thread.
- Also avoid an unnecessary ref cnt bump when we call
PeerConnectionImpl::GetMediaPipelineForTrack by returning a reference
to the RefPtr instead of a copy.

Review commit: https://reviewboard.mozilla.org/r/139882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139882/

Comment 2

[Michael Froman [:mjf]]

Comment on attachment 8868292 [details]
Bug 1365291 - capture 'this' with RefPtr on dispatch to STS thread.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/139882/diff/1-2/

Comment 3

[Michael Froman [:mjf]]

Comment on attachment 8868292 [details]
Bug 1365291 - capture 'this' with RefPtr on dispatch to STS thread.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/139882/diff/2-3/

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8868292 [details]
Bug 1365291 - capture 'this' with RefPtr on dispatch to STS thread.

https://reviewboard.mozilla.org/r/139882/#review144166

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f5e027fe25a
capture 'this' with RefPtr on dispatch to STS thread. r=jib

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0f5e027fe25a