Closed
Bug 1365485
Opened 7 years ago
Closed 7 years ago
Remove GeckoInterface.getDefaultChromeURI
Categories
(GeckoView :: General, enhancement)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(1 file)
|
10.33 KB,
patch
|
droeh
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Add getChromeUri/setChromeUri APIs to GeckoView, to allow each GeckoView's chrome URI to be set individually. This lets us remove GeckoInterface.getDefaultChromeURI. This patch also changes the default URI value to the GeckoView default, and let Fennec specify its chrome URI (browser.xul) inside GeckoApp.
Attachment #8868704 -
Flags: review?(droeh)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8868704 [details] [diff] [review] Remove GeckoInterface.getDefaultChromeURI (v1) Review of attachment 8868704 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #8868704 -
Flags: review?(droeh) → review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1dce43934107 Remove GeckoInterface.getDefaultChromeURI; r=droeh
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1dce43934107
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•5 years ago
|
Target Milestone: Firefox 55 → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•