Closed
Bug 1365635
Opened 7 years ago
Closed 7 years ago
Fix payload queue and damp regression
Categories
(DevTools :: Netmonitor, defect)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: rickychien, Assigned: rickychien)
References
Details
Attachments
(1 file)
Bug 1362678 caused by bug 1344160 (netmonitor-controller refactoring). The key perf impact of queuing NetworkEventUpdate (bug 1358715) was accidentally ignored in bug 1344160. I believe this would be the major key factor that `netmonitor.requestsFinished.DAMP` performs incredibly slow in talos test result https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=autoland&originalRevision=86de1de2f3f39bc225985f182ab992c97648f8a1&newProject=autoland&newRevision=a9339d769d2b03f5a21b8e7a804a0d2d528af1af&originalSignature=36adf201cb660409c00544b0a576c6f86c3eb669&newSignature=36adf201cb660409c00544b0a576c6f86c3eb669&framework=1
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
I'll add pushPayloadToQueue back and see what talos test says.
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8868629 [details] Bug 1365635 - Fix payload queue and damp regression https://reviewboard.mozilla.org/r/140216/#review143878 Ok, let's see if this helps. Honza
Attachment #8868629 -
Flags: review?(odvarko) → review+
Pushed by rchien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cb83c677f01a Fix payload queue and damp regression r=Honza
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cb83c677f01a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•