Closed
Bug 1365686
Opened 7 years ago
Closed 7 years ago
stylo: Turn off parallelism for non-root traversals
Categories
(Core :: CSS Parsing and Computation, enhancement, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
1.03 KB,
patch
|
emilio
:
review+
|
Details | Diff | Splinter Review |
As a very rough first stab at improving the overhead measured in bug 1365682, we can at least stop using the parallelism for everything other than StyleDocument calls, which eliminates all the small traversals. Especially with lazy frame construction, most styling of new content ends running off of ProcessPendingRestyles anyway. It's not perfect, because we may still have some large subtrees that we miss parallelizing, and we could have trivial 1-element restyles in ProcessPendingRestyles. But it's still better than what we have now, and Talos shows that it's quite a bit better than what we have now. We can continue to tweak, but I want to get this into the tree as a starting point to improve our numbers.
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c12397dbb7adbe4da8a50115515fc1fd67d6dbd
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8868682 -
Flags: review?(emilio+bugs)
Assignee | ||
Updated•7 years ago
|
Priority: -- → P1
Updated•7 years ago
|
Attachment #8868682 -
Flags: review?(emilio+bugs) → review+
Assignee | ||
Comment 3•7 years ago
|
||
https://github.com/servo/servo/pull/16930
Assignee | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•