1365760 - Fix two tiny issues in mozJSComponentLoader::ImportInto()

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement)

Comment 1

[Andrew McCreight [:mccr8]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=92966d66cffc4ab7faeef64d2f6a279179a1de8b

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1365760 - Fix two tiny issues in mozJSComponentLoader::ImportInto().

Review commit: https://reviewboard.mozilla.org/r/140748/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140748/

Comment 3

[Andrew McCreight [:mccr8]]

There's a second change to fix some leading whitespace. I don't know why it doesn't show up in mozreview.
-           JS_MarkCrossZoneId(cx, symbolId);
+            JS_MarkCrossZoneId(cx, symbolId);

Comment 4

[Kris Maglione [:kmag]]

Comment on attachment 8869115 [details]
Bug 1365760 - Fix two tiny issues in mozJSComponentLoader::ImportInto().

https://reviewboard.mozilla.org/r/140748/#review144220

Comment 5

[Kris Maglione [:kmag]]

(In reply to Andrew McCreight [:mccr8] from comment #3)
> There's a second change to fix some leading whitespace. I don't know why it
> doesn't show up in mozreview.
> -           JS_MarkCrossZoneId(cx, symbolId);
> +            JS_MarkCrossZoneId(cx, symbolId);

Seems like a bug... It normally tries to mark whitespace-only changes, but there's apparently a toggle to hide them entirely. But flipping it doesn't seem to have any effect.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcb8a85c4663
Fix two tiny issues in mozJSComponentLoader::ImportInto(). r=kmag

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bcb8a85c4663