1366048 - Build Stylo for win32 and win64

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Nathan Froyd [:froydnj]]

This is a matter of getting a Rust with support for `thiscall`:

https://github.com/rust-lang/rust/pull/42058

(not merged or even reviewed at the time of this writing) and then propagating that knowledge into syntex and from there into bindgen.

Comment 1

[Chris Peterson [:cpeterson]]

Because of the time to ship thiscall support in Rust and syntex, we aren't going to block Stylo built-but-disabled waiting for win32 support.

Comment 2

[Chris Peterson [:cpeterson]]

Emilio landed a workaround in rust-bindgen so it doesn't panic when parsing the unrecognized thiscall calling convention. When servo upgrades to a new rust-bindgen release, we should then be able to build Stylo for Win32.

https://github.com/servo/rust-bindgen/pull/722

Comment 3

[Gregory Szorc [:gps]]

Did this bug get sorted out as part of bug 1365254?

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Gregory Szorc [:gps] from comment #3)
> Did this bug get sorted out as part of bug 1365254?

You can use this bug for actually enabling Stylo builds for win32 and win64. That bug just fixed a win32 build problem.

Comment 5

[Gregory Szorc [:gps]]

Attachment: Bug 1366048 - Build stylo on win32 and win64 in automation;

We just did the same for Linux64. Windows CI for this configuration
appears to be happy. So let's do it.

Review commit: https://reviewboard.mozilla.org/r/151522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151522/

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8880148 [details]
Bug 1366048 - Build stylo on win32 and win64 in automation;

https://reviewboard.mozilla.org/r/151522/#review156486

\o/

Comment 7

[Gregory Szorc [:gps]]

I'm going to hold off landing this until we know the backout service works.

Comment 8

[Gregory Szorc [:gps]]

We're still having some issues with VCS backout syncing. Rather than land this and increase the odds of things breaking, I'm going to wait until things are in a better state, likely by the middle of next week at the latest. Plus some regressions from Linux64 are still being worked out. Plus it is a Friday and I don't like fire fighting on the weekend.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06ec956f7533
Build stylo on win32 and win64 in automation; r=froydnj

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/06ec956f7533

Comment 11

[Kevin Brosnan [Ex-Mozilla]]

This caused a 1.9 MB jump in installer size on Win 64 PGO.

Comment 12

[Gregory Szorc [:gps]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #11)
> This caused a 1.9 MB jump in installer size on Win 64 PGO.

That was expected (we're building/shipping new code) and is similar to what was seen on Linux (see bug 1374824 comment 22).

I can't answer whether that is a reasonable amount of size increase. (It probably is.)