1366075 - Devedition funsize jobs should use "firefox" prefix in "to_mar"

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement, P1)

Description

[Rail Aliiev [:rail]]

https://github.com/mozilla/releasetasks/blob/21ce74e75801f08ca8b1dc3de25e550d1e6e766e/releasetasks/templates/desktop/l10n.yml.tmpl#L195 uses {{ product }} for the file name, which is "devedition", but repacks generate files with "firefox" prefix. We should either parameterize this or hardcode "firefox" (what just worked fine in staging :) ).

Comment 1

[Rail Aliiev [:rail]]

The same applies to FILENAME_TEMPLATE env variables set in enUS and l10n templates

Comment 2

[Johan Lorenzo [:jlorenzo]]

Attachment: releasetasks PR

Comment 3

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1366075 - Devedition funsize jobs should use "firefox" prefix in "to_mar"

Review commit: https://reviewboard.mozilla.org/r/141514/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141514/

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8869495 [details] [review]
releasetasks PR

Sorry to bother you. Simon realized he doesn't have the right to formally review releasetasks, and I'm not able to override the review requirement.

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8869958 [details]
Bug 1366075 - Devedition funsize jobs should use "firefox" prefix in "to_mar"

https://reviewboard.mozilla.org/r/141514/#review145494

::: buildfarm/release/release-runner.py:511
(Diff revision 1)
>                  "update_verify_channel": branchConfig.get("update_verify_channel", {}).get(release["product"]),
>                  "update_verify_requires_cdn_push": branchConfig.get("update_verify_requires_cdn_push", False),
>              }
>  
>              validate_graph_kwargs(queue, gpg_key_path, **kwargs)
>              graph = make_task_graph_strict_kwargs(**kwargs)

You also need to touch `make_task_graph_strict_kwargs()` to make it accept the new argument and adjust https://dxr.mozilla.org/build-central/source/tools/buildfarm/release/releasetasks_graph_gen.py#36 to match the current kwargs for consistency.

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8869958 [details]
Bug 1366075 - Devedition funsize jobs should use "firefox" prefix in "to_mar"

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141514/diff/1-2/

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 8869958 [details]
Bug 1366075 - Devedition funsize jobs should use "firefox" prefix in "to_mar"

https://reviewboard.mozilla.org/r/141514/#review145514

Comment 8

[Johan Lorenzo [:jlorenzo]]

Attachment 8869958 [details] landed on default at https://hg.mozilla.org/build/tools/rev/6615ff0a8876c60f3fb873ddd7e6c373ba568767

Comment 9

[Johan Lorenzo [:jlorenzo]]

https://github.com/mozilla/releasetasks/commit/421d8606a93ec51afde19e413950aac26985fbb0

BM85 has been manually updated[1]

[1] Some of the steps are documented here https://github.com/mozilla/releasewarrior/blob/b5094a978955425b867be725fb555707006f637a/how-tos/fennec-temp-relpro.md#start-off-the-fennec-graph mtabara++

Comment 10

[Rail Aliiev [:rail]]

followup fix: https://hg.mozilla.org/build/tools/rev/ede5d6057708