Closed
Bug 1366151
Opened 7 years ago
Closed 7 years ago
rewrite dom/html/test/test_fullscreen-api-race.html
Categories
(Core :: DOM: Security, enhancement, P2)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file, 2 obsolete files)
1.46 KB,
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
now the test hits assertion even without flip the pref, bug 1365844
Assignee | ||
Comment 2•7 years ago
|
||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Assignee | ||
Comment 3•7 years ago
|
||
This one has lots of intermittent failures even without my patch and without flip the pref, Henry is fixing some in his bug 1355746. I'll wait to see if his patch could help the intermittent here.
Comment 4•7 years ago
|
||
Per Heny, bug 1355746 is not a blocker for this bug. Henry, please elaborate it. Thanks!
Flags: needinfo?(hchang)
Comment 5•7 years ago
|
||
(In reply to Ethan Tseng [:ethan] from comment #4) > Per Heny, bug 1355746 is not a blocker for this bug. Henry, please > elaborate it. Thanks! The relevant patch in bug 1355746 is to fix test_fullscreen-api.html intermittent failure caused by a fullscreen focus issue on Linux so I am not expecting that patch to fix test_fullscreen-api-race.html
Flags: needinfo?(hchang)
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #8877940 -
Attachment is obsolete: true
Attachment #8894822 -
Flags: review?(bugs)
Comment 7•7 years ago
|
||
Comment on attachment 8894822 [details] [diff] [review] Patch. // SimpleTest.waitForFocus will fire only when we use data: URI. sounds wrong. But if we don't want to change data: usage here, this is fine, but without that comment.
Attachment #8894822 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 8•7 years ago
|
||
updated comments
Attachment #8894822 -
Attachment is obsolete: true
Attachment #8895180 -
Flags: review+
Pushed by yhuang@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f39222925a5f rewrite dom/html/test/test_fullscreen-api-race.html. r=smaug
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f39222925a5f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•