Closed Bug 1366151 Opened 7 years ago Closed 7 years ago

rewrite dom/html/test/test_fullscreen-api-race.html

Categories

(Core :: DOM: Security, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file, 2 obsolete files)

      No description provided.
now the test hits assertion even without flip the pref, bug 1365844
Status: NEW → ASSIGNED
Priority: -- → P2
This one has lots of intermittent failures even without my patch and without flip the pref, Henry is fixing some in his bug 1355746. I'll wait to see if his patch could help the intermittent here.
Per Heny, bug 1355746 is not a blocker for this bug.  Henry, please elaborate it.  Thanks!
Flags: needinfo?(hchang)
(In reply to Ethan Tseng [:ethan] from comment #4)
> Per Heny, bug 1355746 is not a blocker for this bug.  Henry, please
> elaborate it.  Thanks!

The relevant patch in bug 1355746 is to fix test_fullscreen-api.html
intermittent failure caused by a fullscreen focus issue on Linux so I
am not expecting that patch to fix test_fullscreen-api-race.html
Flags: needinfo?(hchang)
Attached patch Patch. (obsolete) — Splinter Review
Attachment #8877940 - Attachment is obsolete: true
Attachment #8894822 - Flags: review?(bugs)
Comment on attachment 8894822 [details] [diff] [review]
Patch.

// SimpleTest.waitForFocus will fire only when we use data: URI.
sounds wrong.
But if we don't want to change data: usage here, this is fine, but without that comment.
Attachment #8894822 - Flags: review?(bugs) → review+
Attached patch Patch v2.Splinter Review
updated comments
Attachment #8894822 - Attachment is obsolete: true
Attachment #8895180 - Flags: review+
Pushed by yhuang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f39222925a5f
rewrite dom/html/test/test_fullscreen-api-race.html. r=smaug
https://hg.mozilla.org/mozilla-central/rev/f39222925a5f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: