1366218 - HTMLInputElement::IsValueEmpty should use nsTextEditorState::HasNonEmptyValue

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Makoto Kato [:m_kato]]

HasNonEmptyValue doesn't use DocumentEncoder, so IsValueEmpty can be improved.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1366218 - Use fast path to check empty value.

HTMLInputElement::IsValueEmpty uses DocumentEncoder when input element has focus.  DocumentEncoder is slow, so we should use fast path (nsTextEditorState::HasNonEmptyValue) to check whether value is empty.

Review commit: https://reviewboard.mozilla.org/r/141710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141710/

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8870258 [details]
Bug 1366218 - Use fast path to check empty value.

https://reviewboard.mozilla.org/r/141710/#review145528

Bogus node handling in editor is weird, but I guess this should do the trick

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffaa07672466
Use fast path to check empty value. r=smaug

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ffaa07672466