1366345 - Ctrl-enter shortcut isn't working when manually adding a bug

Status: RESOLVED FIXED

(Tree Management :: Treeherder, enhancement)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

The patch from bug 1305507 doesn't seem to be working anymore for some reason. When the manual bug entry field is focused, the Ctrl-Enter shortcut doesn't trigger at all, like it's stealing all focus and not emitting the event.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:b1366345 > mozilla:master

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8869552 [details] [review]
[treeherder] KWierso:b1366345 > mozilla:master

Redirecting to Cameron, since he might know if there's a better way to do this :-)

Comment 3

[Cameron Dawson [:camd]]

As I stated in the PR, I wouldn't worry about the ``meta`` key which corresponds to the mac "command" key.  Since the user guide only says ``ctrl`` I'd just go with that.

Interesting this stopped working at some point.  I suspect it was a JS upgrade somewhere (perhaps AngularJS itself?) that happened a while back and nobody noticed till recently.  :)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/da2c74b8b1b53829a932e851d0e9c1690b7801b2
Bug 1366345 - Force the save() event to be emitted when ctrl-enter is used while manually entering bug numbers (#2494) r=camd

Something is eating the event fired when ctrl-enter is pressed to save classifications if the manual bug number field is focused, making the user press ctrl-enter twice to save the classification.  This patch adds a keypress listener to the bug entry field which forces the save() function to get called when ctrl-enter is pressed.