1366366 - Remove animation from new robot icon as introduced in bug

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Since the patch on bug 1355890 landed we see a lot of test failures for the full screenshot test on bug 1364762. As investigation on bug 1364762 has shown this happens because the robot is animated (rolling eyes).

I wonder if we should better remove this animation.

Comment 1

[Andreas Tolfsen ❲:ato❳]

I think removing the animation is prudent.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Andreas, this is the reason for bug 1364762 which has a massive increase of failures. For last week it's the #3 top OF failure. So we need to remove the animation or skip the test ASAP. Thanks.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Screenshot (overdrawn locationbar border)

Also it looks like that we overdraw the location bar border.

Comment 4

[Andreas Tolfsen ❲:ato❳]

Not sure what the needinfo is for.

Comment 5

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1366366 - Use non-animated robot icon with Marionette;

The browser/base/content/robot.ico resource is animated, displaying
a robot that occasionally rolls its eyes.  This causes fallouts
when taking screenshots of the entire ChromeWindow area, such as
https://bugzilla.mozilla.org/show_bug.cgi?id=1364762.

This patch provides a PNG copy of the robot that does not roll its eyes
for use with Marionette.

Review commit: https://reviewboard.mozilla.org/r/141844/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141844/

Comment 6

[:Gijs (he/him)]

Comment on attachment 8870394 [details]
Bug 1366366 - Use non-animated robot icon with Marionette;

https://reviewboard.mozilla.org/r/141844/#review145490

rs=me, but can we either name this 'static-robot' or something, or rename the other icon, to avoid this happening to other people who accidentally use the 'wrong' icon? :-)

Comment 7

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8870394 [details]
Bug 1366366 - Use non-animated robot icon with Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141844/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d90b1a36e1a
Use non-animated robot icon with Marionette; r=Gijs

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5d90b1a36e1a