1366536 - stylo: Decide whether we should check important rule changes for all properties or not

Status: NEW

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Hiroyuki Ikezoe (:hiro)]

In bug 1334036, we are checking important rule changes for *all* properties and creating SequentialTask if there are any important rule changes, and request a restyle in the SequentialTask.  But we don't effectively use the information (I mean the important rule changes for *all* property).  If we have such information, we should fix bug 1300982 or bug 1300983.

That's being said, the check (and creating SequentialTask and request restyle) pays some amount of costs, I don't think it's a good idea that the costs are included in stylo release, we should do it apart from stylo release.

So, I'd suggest to check important rule changes only for opacity and transform properties before creating the SequentialTask.

Brian, what do you think?

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

If we only need to do it for opacity and transform for now to preserve current behavior I agree we should do that.

Comment 2

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Nice to have, P4. If this is an important optimization, please let me know.

Comment 3

[Chris Peterson [:cpeterson]]

status-firefox57=wontfix unless someone thinks this bug should block 57