1366678 - (photon) Frequency search result visual refresh

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Jing-wei Wu [:jwu]]

Attachment: Bug 1366678 - Highlight substrings in search suggestion/history if they match search term.

Review commit: https://reviewboard.mozilla.org/r/156414/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156414/

Comment 2

[Julian Chu [:walkingice]]

Comment on attachment 8885594 [details]
Bug 1366678 - Highlight substrings in search suggestion/history if they match search term.

https://reviewboard.mozilla.org/r/156414/#review161902

::: mobile/android/app/src/photon/java/org/mozilla/gecko/home/SearchEngineRow.java:220
(Diff revision 1)
> -            int nextStartSpanIndex = 0;
> -            // Done to make sure that the stretch of text after the last occurrence, till the end of the suggestion, is made bold
> -            mOccurrences.add(suggestion.length());
>              for (int occurrence : mOccurrences) {
>                  // Even though they're the same style, SpannableStringBuilder will interpret there as being only one Span present if we re-use a StyleSpan
> -                StyleSpan boldSpan = new StyleSpan(Typeface.BOLD);
> +                final StyleSpan boldSpan = new StyleSpan(Typeface.BOLD);

just curious. Is it possible move this out of for-loop?

::: mobile/android/base/java/org/mozilla/gecko/home/TwoLinePageRow.java:62
(Diff revision 1)
>      private String mPageUrl;
>  
>      private boolean mHasReaderCacheItem;
>  
> +    // Use this interface to decorate content in title view.
> +    interface TitleFormatter {

I think move the interface declaration to the bottom of file would be better.

::: mobile/android/base/java/org/mozilla/gecko/home/TwoLinePageRow.java:63
(Diff revision 1)
>  
>      private boolean mHasReaderCacheItem;
>  
> +    // Use this interface to decorate content in title view.
> +    interface TitleFormatter {
> +        @Nullable Spannable format(@NonNull CharSequence title);

what if we return the original CharSequence if nothing be formatted, instead of returning null? This behavior is more like *decorator*

Comment 3

[Jing-wei Wu [:jwu]]

Comment on attachment 8885594 [details]
Bug 1366678 - Highlight substrings in search suggestion/history if they match search term.

https://reviewboard.mozilla.org/r/156414/#review161902

> just curious. Is it possible move this out of for-loop?

SpannableStringBuilder uses a IdentityHashMap to keep the relationship between the span and its range(start and end position). The key value of the map is the span's hashCode().

If we re-use the span, the map would always return same range that cause only one match can be styled.

Comment 4

[Jing-wei Wu [:jwu]]

Comment on attachment 8885594 [details]
Bug 1366678 - Highlight substrings in search suggestion/history if they match search term.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156414/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/967111e5be01
Highlight substrings in search suggestion/history if they match search term. r=walkingice

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/967111e5be01

Comment 7

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 56.0a1, (2017-08-10).
Devices: 
Huawei Honor 8 (Android 6.0)
Motorola Nexus 6 (Android 7.0)
Prestigio Grace X5 (Android 4.4.2)
Huawei Honor 8 (Android 6.0)