Closed Bug 1366681 Opened 7 years ago Closed 7 years ago

Move Add-On to the first level menu

Categories

(Firefox for Android Graveyard :: Add-on Manager, enhancement, P2)

Product:
Firefox for Android Graveyard
Component:
Add-on Manager
Type:
enhancement

Tracking

(fennec+, firefox56 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
fennec + ---
firefox56 --- verified

People

(Reporter: wesley_huang, Assigned: walkingice, NeedInfo)

References

Details

(Whiteboard: triaged)

Attachments

(2 files)

Bug 1366681 - Try to move Add-On to the first level menu
59 bytes, text/x-review-board-request
sebastian
: review+
Details
ScreenShot
69.66 KB, image/jpeg
Details 
Front-end effort to move the add-on option to 1st level so that user can access it more easily
I think someone on the Taipei team was are going to take this on?
Priority: -- → P2
Whiteboard: triaged
Yes, I am going to take this one.
Assignee: nobody → walkingice0204
Comment on attachment 8873318 [details]
Bug 1366681 - Try to move Add-On to the first level menu

https://reviewboard.mozilla.org/r/144780/#review148700

LGTM.

FYI: In the past we did this for history and bookmarks. Back then we moved this move behind a switchboard flag ("bookmark-history-menu") to run an A/B experiment and see how this affects usage.
Attachment #8873318 - Flags: review?(s.kaspari) → review+
Sebastian: Thanks, Good to know! Let me ask product manager to see whether should we involve switchboard here.
according to the funnel meeting today: YES. it'll be great to use switchboard.
I updated the patch to use SwitchBoard. For a target user, to display AddOns menu item in top-level menu. Otherwise, keep the menu item is original place.

Still don't know how to clear review flag. (D'oh)
Comment on attachment 8873318 [details]
Bug 1366681 - Try to move Add-On to the first level menu

https://reviewboard.mozilla.org/r/144780/#review157698
Attachment #8873318 - Flags: review+
Keywords: checkin-needed
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 4dc274291ee1 -d 3c6fba8e4015: rebasing 404190:4dc274291ee1 "Bug 1366681 - Try to move Add-On to the first level menu r=sebastian" (tip)
merging mobile/android/app/src/main/res/menu-large/browser_app_menu.xml and mobile/android/base/resources/menu-large/browser_app_menu.xml to mobile/android/app/src/main/res/menu-large/browser_app_menu.xml
merging mobile/android/app/src/main/res/menu-xlarge/browser_app_menu.xml and mobile/android/base/resources/menu-xlarge/browser_app_menu.xml to mobile/android/app/src/main/res/menu-xlarge/browser_app_menu.xml
merging mobile/android/app/src/main/res/menu/browser_app_menu.xml and mobile/android/base/resources/menu/browser_app_menu.xml to mobile/android/app/src/main/res/menu/browser_app_menu.xml
merging mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
merging mobile/android/base/java/org/mozilla/gecko/Experiments.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/Experiments.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Rebased my patch to m-c. Thanks!
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b51a135ae25
Try to move Add-On to the first level menu r=sebastian
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2b51a135ae25
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Do we have any kind of telemetry to see if this helped add-on usage?

Also I'm wondering .. with the move to WebExtensions in 57 - isn't there a high chance that we annoy users: We encourage them to install add-ons and them we might take them away in 57 (if they are using the legacy API).
In `BrowserApp.onOptionsItemSelected` we have telemetry to record which menu item is clicked, I think we can compare the usage between *R.id.addons* and *R.id.addons_top_level*.

yeah I am also wondering about that. We planned to do this months ago since we wanted to promote WebExtensions, and it is likely we don't have enough resource to take care of this topic anymore. Joe, do you have any idea?
Flags: needinfo?(jcheng)
QA Contact: ioana.chiorean
Attached image ScreenShot — 
Add-ons options it is at 1st level access in settings
As seen in the attached screenshot in previous comment, the option is now at 1st level access. 
Marking bug as verified fixed.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
Depends on: 1381384
No longer depends on: 1381384
I believe we have other telemetry to understand Android add-on usage
pinging AndyM 

"with the move to WebExtensions in 57 - isn't there a high chance that we annoy users: We encourage them to install add-ons and them we might take them away in 57 (if they are using the legacy API)."

I'd like to hear what Add-on team thinks about this as they've been preparing for this. I believe we should have alternative WebExtentions for users if their existing add-on aren't available (at least the top ones)
Flags: needinfo?(jcheng) → needinfo?(amckay)
There is a discussion about an incompatible badge on mobile pages here: https://github.com/mozilla/addons-frontend/issues/2754. If you feel it will make a difference, feel free to delay it to 57 when everything will be WebExtensions only.
Flags: needinfo?(amckay)
Hi Joe
Do we still need this experiment?
? for triage discussion
tracking-fennec: --- → ?
Flags: needinfo?(jcheng)
tracking-fennec: ? → +
See Also: → 1432639
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: