Closed
Bug 1366791
Opened 7 years ago
Closed 7 years ago
browser_ext_geckoProfiler_symbolicate.js does not wait for preferences to be set
Categories
(Core :: Gecko Profiler, defect)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file)
|
1.09 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
This test flips some prefs necessary to test the gecko profiler: https://dxr.mozilla.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_geckoProfiler_symbolicate.js Unfortunately, though, it does not actually wait for the prefs to be written before proceeding. This causes some failures with my patches in bug 1363829 since things run slightly faster.
|
Assignee | |
Comment 1•7 years ago
|
||
Please see comment 0 for a description of the problem. Basically we just need to yield until pushPrefEnv() completes writing the preferences.
Attachment #8870055 -
Flags: review?(mstange)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8870055 [details] [diff] [review] Make browser_ext_geckoProfiler_symbolicate.js wait for prefs to be written. r=mstange Review of attachment 8870055 [details] [diff] [review]: ----------------------------------------------------------------- thanks
Attachment #8870055 -
Flags: review?(mstange) → review+
Pushed by bkelly@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1c96cb8ecabf Make browser_ext_geckoProfiler_symbolicate.js wait for prefs to be written. r=mstange
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1c96cb8ecabf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•