136686 - "original filename" is empty in version info

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Henrik Gemal]

version information in the file properties is at the best bad:

- "fileversion" on files (fx ISimpleDOMDocumentMarshal.dll) are 0.0.0.0
- "description" is empty
- "Company name" should be "Mozilla.org" not "Mozilla"
- "Legal trademark" should perhaps mention MPL, etc
- "Original filename" is empty

Comment 1

[hacker formerly known as [e-mail]]

-> aki

Comment 2

[Aki Sasaki]

0.0.0.0 becomes something else when:

1) config/milestone.txt is x.x.x or x.x.x.x (-not- x.x.x+)
2) BUILD_OFFICIAL and/or MOZILLA_OFFICIAL are set.

The other stuff is cosmetic for the most part, so wasn't as urgent to get in. 
Should all be tweakable in config/version_win.pl, which I'll take a look at when
I have time.

Comment 3

[Aki Sasaki]

1) is intentional
2) is taken care of in bug 138764
3) marking wontfix...
4) marking wontfix...

changing summary to "original filename is empty"

Comment 4

[Aki Sasaki]

Attachment: mozilla patch for original filename

Comment 5

[Aki Sasaki]

Attachment: updated mozilla trunk patch

Comment 6

[Aki Sasaki]

Attachment: commercial trunk patch

wasn't sure if i should nuke version.inc or patch it... this has the patch.

Comment 7

[Aki Sasaki]

got original filename working.  cls, could i get r=?

Comment 8

[hacker formerly known as [e-mail]]

Comment on attachment 99553 [details] [diff] [review]
updated mozilla trunk patch

r=cls

Comment 9

[hacker formerly known as [e-mail]]

Comment on attachment 99555 [details] [diff] [review]
commercial trunk patch

r=cls

Comment 10

[Aki Sasaki]

checked into the trunk.