1366919 - mozregression OS detection doesn't work under MSYS2 on Windows

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Ed Morley [:emorley]]

Using MSYS2 on Windows 10 with Python installed via MSYS2, I get:

$ mozregression --good 2016-06-01
...
 0:00.09 ERROR: mozregression supports linux, mac and windows but your os is reported as 'UNKNOWN'.

Changing this mozinfo line:

> elif system.startswith('MINGW'):
(https://hg.mozilla.org/mozilla-central/file/f9ca97a334296facd2e0ea5582e7f12d0fe70fe4/testing/mozbase/mozinfo/mozinfo/mozinfo.py#l90)

...to this fixes the issue:

> elif system.startswith('MINGW') or system.startswith('MSYS_NT'):

Since:

$ python -c 'import platform; print platform.uname()[0]'
MSYS_NT-10.0

Comment 1

[William Lachance (:wlach)]

Thanks Ed! I guess I'll take this one.

Steps:

1. Make emorley's change
2. Bump version of mozinfo and push new version to pypi
3. Release new version of mozregression w/ updated dependency

Comment 2

[William Lachance (:wlach)]

Attachment: Bug 1366919 - Consider MSYS_NT to equal windows in mozinfo

Review commit: https://reviewboard.mozilla.org/r/141912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141912/

Comment 3

[William Lachance (:wlach)]

Attachment: Bug 1366919 - Bump mozinfo version to 0.10

Review commit: https://reviewboard.mozilla.org/r/141914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141914/

Comment 4

[Ed Morley [:emorley]]

Many thanks!

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 8870484 [details]
Bug 1366919 - Consider MSYS_NT to equal windows in mozinfo

https://reviewboard.mozilla.org/r/141912/#review149796

Comment 6

[Andrew Halberstadt [:ahal]]

Comment on attachment 8870485 [details]
Bug 1366919 - Bump mozinfo version to 0.10

https://reviewboard.mozilla.org/r/141914/#review149798

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88b1189b4fdd
Consider MSYS_NT to equal windows in mozinfo r=ahal
https://hg.mozilla.org/integration/autoland/rev/6ebd3de09d6c
Bump mozinfo version to 0.10 r=ahal

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/88b1189b4fdd
https://hg.mozilla.org/mozilla-central/rev/6ebd3de09d6c