1367002 - [Linux] Sidebar switcher widget and close button lack a focus ring

Status: RESOLVED DUPLICATE of bug 1616324

(Firefox :: Theme, defect, P4)

Description

[Dão Gottwald [:dao]]

I see this on Linux, haven't checked elsewhere. It looks like the close button already had this problem prior to bug 1355324.

Comment 1

[:Gijs (he/him)]

Focus rings work fine on Windows. Not sure why it's broken on Linux off-hand.

Comment 2

[Dão Gottwald [:dao]]

(In reply to :Gijs from comment #1)
> Focus rings work fine on Windows. Not sure why it's broken on Linux off-hand.

Likely because Gtk usually renders these for toolbarbuttons and buttons and native widget styling was disabled here.

Comment 3

[u554753]

Can you provide some clarification or screenshot of what the focus indicator/ring would be? Thanks!

Comment 4

[Dão Gottwald [:dao]]

(In reply to Grover Wimberly IV [:Grover-QA] from comment #3)
> Can you provide some clarification or screenshot of what the focus
> indicator/ring would be? Thanks!

Either the native focus ring from the OS or a dotted outline would be fine.

Comment 5

[u554753]

Attachment: Screenshot from 2017-07-03 16-05-47.png

Does this attachment show the focus indicator around "Move Sidebar to the Left"? If yes, it seems to have been resolved in the newest version of Nightly on Ubuntu.

Comment 6

[Dão Gottwald [:dao]]

(In reply to Grover Wimberly IV [:Grover-QA] from comment #5)
> Created attachment 8883125 [details]
> Screenshot from 2017-07-03 16-05-47.png
> 
> Does this attachment show the focus indicator around "Move Sidebar to the
> Left"? If yes, it seems to have been resolved in the newest version of
> Nightly on Ubuntu.

This is neither a focus ring nor is this bug about the "Move Sidebar to the Left" item; it's about the button that opens that popup and about the sidebar close button.

Comment 7

[u554753]

Okay, this brings me back to my original question from Comment 3.

Comment 8

[:Gijs (he/him)]

(In reply to Grover Wimberly IV [:Grover-QA] from comment #7)
> Okay, this brings me back to my original question from Comment 3.

On Windows, if you follow these STR:

1. open bookmarks/history/whatever sidebar
2. click into the search field
3. hit shift-tab once

- you see a dotted line around the [x] button

4. hit shift-tab another time

- you see a dotted line around the header button.

When these dotted lines appear, they indicate the button has focus. Hitting space or enter on the keyboard activates the button (this also works for me on Windows).

This bug is about the fact that if you follow the same steps on Linux, no indicator of which button is focused appears.

Comment 9

[Asif Youssuff]

This looks fixed to me in Nightly. Is this still an issue, Dão?