Closed
Bug 1367047
Opened 7 years ago
Closed 7 years ago
Toolbar button hover feedback is barely visible on dark backgrounds
Categories
(Firefox :: Theme, defect, P1)
Firefox
Theme
Tracking
()
People
(Reporter: dao, Assigned: dao)
References
Details
(Whiteboard: [photon-visual][p1][57])
Attachments
(1 file)
I see this on Ubuntu where the tab bar is dark. Affects lightweight themes too. This needs adjustments for toolbar[brighttext].
Updated•7 years ago
|
Flags: qe-verify?
Priority: -- → P2
Whiteboard: [photon-visual][p1][57][triage] → [photon-visual][p1][57]
Updated•7 years ago
|
Flags: qe-verify? → qe-verify+
QA Contact: brindusa.tot
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Updated•7 years ago
|
Iteration: --- → 55.7 - Jun 12
Priority: P2 → P1
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8873374 [details] Bug 1367047 - Make toolbar button backgrounds more visible on dark toolbars. https://reviewboard.mozilla.org/r/144814/#review148880 The back button styling seems off in the dark compact theme (at least on macOS). The background-{origin,clip} rules are getting overridden because the hover styling is setting `background: bla;` instead of background-color. Also, seems like the spec has a lighter background on hover and even lighter on active for the back button. (https://people-mozilla.org/~shorlander/projects/photon/Mockups/macOS.html) Additionally, active state feedback for the other toolbar buttons is too similar to the hover state, want to fix that in this bug as well? ::: browser/themes/windows/browser.css:67 (Diff revision 1) > :root { > --panel-separator-color: hsla(210,4%,10%,.14); > } > } > > +%ifdef MOZ_PHOTON_THEME Aren't these old styles? Did you mean to %ifndef?
Attachment #8873374 -
Flags: review?(nhnt11)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Nihanth Subramanya [:nhnt11] from comment #2) > Additionally, active state feedback for the other toolbar buttons is too > similar to the hover state, want to fix that in this bug as well? Not sure what you mean here. I've tweaked the colors a bit, is it better now? FWIW, I'm using more opacity than in the "Dark" mockup since the background colors used there are too subtle to be visible enough on noisy lightweight theme backgrounds.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8873374 -
Flags: review?(nhnt11) → review?(jhofmann)
Updated•7 years ago
|
Attachment #8873374 -
Flags: review?(jhofmann)
Updated•7 years ago
|
Attachment #8873374 -
Flags: review?(nhnt11)
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8873374 [details] Bug 1367047 - Make toolbar button backgrounds more visible on dark toolbars. https://reviewboard.mozilla.org/r/144814/#review151796 Looks good, thanks!
Attachment #8873374 -
Flags: review?(nhnt11) → review+
Assignee | ||
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8873374 [details] Bug 1367047 - Make toolbar button backgrounds more visible on dark toolbars. https://reviewboard.mozilla.org/r/144814/#review151798
Attachment #8873374 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Attachment #8873374 -
Flags: review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/38edb8755b92 Make toolbar button backgrounds more visible on dark toolbars. r=nhnt11
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/38edb8755b92
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 10•7 years ago
|
||
It's probably interesting to take a look at before and after on all platforms in mozscreenshots: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=2d20b365eee19434657f6b365d310e8b70904d2b&newProject=mozilla-central&newRev=d0e38542a05b17dd87586281b5d324112d38f6ca Unfortunately OSX screenshots is still blocked on bug 1369425.
Comment 11•7 years ago
|
||
I tested this issue on Ubuntu 16.04 x64, Windows 10 x64, Windows 7 x32 and Windows 8 x64 with FF Nightly 57.0a1(2017-08-07) and everything works as expected. Note: On Windows 7 the back button has a square shape and on all other OSes the back button has a round shape.
Status: RESOLVED → VERIFIED
status-firefox57:
--- → verified
Updated•7 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•