Closed Bug 1367149 Opened 7 years ago Closed 7 years ago

Sidebar splitter should use an OS color

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Iteration:
56.1 - Jun 26
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- wontfix
firefox56 --- fixed
firefox57 --- verified

People

(Reporter: dao, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [photon-visual][p3] fixed by bug 1367242) 

Bug 1355324 hardcoded this to #ccc, which is alright for Mac but not for Windows and Linux where we support different OS themes.
Whiteboard: [photon-structure] → [photon-structure] [triage]
Flags: qe-verify?
Priority: -- → P2
Whiteboard: [photon-structure] [triage] → [photon-structure]
Priority: P2 → P3
Whiteboard: [photon-structure] → [reserve-photon-structure]
Blocks: photon-visual
status-firefox53: --- → unaffected
status-firefox54: --- → unaffected
status-firefox55: --- → affected
Flags: qe-verify? → qe-verify+
Keywords: regression
Priority: P3 → P2
Whiteboard: [reserve-photon-structure] → [photon-visual][p3]
QA Contact: brindusa.tot
Depends on: 1367242
Reading the [photon-visual] whiteboard, I am guessing this issue seems on simply Nightly for now. This doesn't sound like a blocker for Release 55, right?
Flags: needinfo?(mmucci)
Flags: needinfo?(dao+bmo)
(In reply to Hsin-Yi Tsai (55 Regression Engineering support) [:hsinyi] from comment #1)
> Reading the [photon-visual] whiteboard, I am guessing this issue seems on
> simply Nightly for now. This doesn't sound like a blocker for Release 55,
> right?

I don't know about blocker, but this will affect 55. The sidebar code is just shipping, it's not behind prefs/ifdefs. The whiteboard just means that the photon-visual team intends to look at it.
This has been fixed by bug 1367242 for Firefox 56, still affects but doesn't need to block Firefox 55.
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55: affected → wontfix
status-firefox56: --- → fixed
Flags: needinfo?(mmucci)
Flags: needinfo?(dao+bmo)
Resolution: --- → FIXED
Whiteboard: [photon-visual][p3] → [photon-visual][p3] fixed by bug 1367242
Target Milestone: --- → Firefox 56
Iteration: --- → 56.1 - Jun 26
Priority: P2 → P1
No longer depends on: 1377003
Hi Dão, 

What do we need to verify here? 
Also based on the fact that this bug was fixed by bug 1267242, it will be ok to mark it verified? Thanks
Flags: needinfo?(dao+bmo)
Verify that the sidebar splitter changes its color based on the OS theme. I would check Windows default themes vs. dark and white High Contrast themes, and maybe a few of different Gtk themes on Linux.
Flags: needinfo?(dao+bmo)
I verified this issue on Windows 10 x64 and Ubuntu 16.04 with FF Nightly 57.0a1(2017-08-10) and I can confirm the fact that the sidebar splitter changes its color based on the OS theme. Thanks Dão for help.
Status: RESOLVED → VERIFIED
status-firefox57: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.