1367538 - DrawTargetRecordings are kept alive by ScaledFonts

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Jeff Muizelaar [:jrmuizel]]

DrawTargetRecording::FillGlyph adds a UserData containing a reference to the Recording. This keeps the recordings alive as long as the ScaledFont is around. This is likely not the best. We only want the UserData around while we're recording. After we're done we don't need them anymore.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

SourceSurfaces do this too which seems to be an even greater cause of staying around.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Clear user data after we're done with the recorder

This helps keep us from accumulating all of the recorders. 

The basic idea is to track weak references to the SourceSurfaces and Fonts that we add UserData to in DrawEventRecorderPrivate and then clear these UserData's when we're done recording.

This adds a RemoveAndDestroy helper to UserData to make this possible.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f65427cd949
Clear user data after we're done with the recorder. r=lsalzman

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5f65427cd949