1367654 - Clean up ProfileEntry

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement)

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Clean up ProfileEntry

This patch:

- renames flags_ as flagsAndCategory_ because it contains both the flags and
  the category;

- uses << for some bitfield definitions, because it's easier to read;

- removes some dead methods from ProfileEntry;

- removes the unnecessary JS_FRIEND_API from setPC().

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - In GeckoProfiler.h, rename Sampler* as Profiler*

Because everything else in this file is called ProfilerFoo or PROFILER_FOO.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Remove unnecessary BEGIN_PSEUDO_JS frame from AutoGeckoProfilerEntry

BEGIN_PSEUDO_JS frames are necessary before a sequence of JS frames, in order
to provide a stack address. But in AutoGeckoProfilerEntry the BEGIN_PSEUDO_JS
frame is before a C++ frame, so it's useless.

Comment 4

[Nicholas Nethercote [inactive]]

Try server looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=224cc9d5f69ebd04b988b635e509e56a5f46122d

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b82e5e570d6e28138167115fe74a2d5d32c9e07
Bug 1367654 (part 1) - Clean up ProfileEntry. r=shu.

https://hg.mozilla.org/integration/mozilla-inbound/rev/343d001b8dfe9746d5423d0d1fca61c248805cc9
Bug 1367654 (part 2) - In GeckoProfiler.h, rename Sampler* as Profiler*. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/735a87a03948ba9462017b37f64fed601444c7cd
Bug 1367654 (part 3) - Remove unnecessary BEGIN_PSEUDO_JS frame from AutoGeckoProfilerEntry. r=shu.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7b82e5e570d6
https://hg.mozilla.org/mozilla-central/rev/343d001b8dfe
https://hg.mozilla.org/mozilla-central/rev/735a87a03948