Open
Bug 1367999
Opened 7 years ago
Updated 2 years ago
Got leak messages when close firefox
Categories
(Core :: General, defect, P3)
Core
General
Tracking
()
NEW
People
(Reporter: JamesCheng, Unassigned)
Details
(Keywords: stale-bug, Whiteboard: [MemShrink:P3])
Attachments
(1 obsolete file)
When ./mach run firefox Open a youtube link then close the firefox. I will get leak message as below.(100% reproducing under e10s) Notice: If you have more than one tab(one is playing youtube), closing the tab will "not" get the leak message. Leaked URLs: https://s.youtube.com/api/stats/watchtime?ns=yt&el=detailpage&cpn=7_ujQ21n80-Ke3AR&docid=qoPupXWVhAw&ver=2&referrer=https%3A%2F%2Fwww.youtube.com%2F&cmt=4.102&plid=AAVQaYo0O91_Flkq&ei=L-4nWYedNsqf4AKAxKqoBw&fmt=243&fs=0&rt=5.196&of=L_PUY4Nf_LYjMBZyfTtRvg&euri&lact=5753&cl=156902750&state=paused&vm=CAEQABgE&c=WEB&cver=1.20170523&cplayer=UNIPLAYER&cbr=Firefox&cbrver=55.0&cos=X11&final=1&hl=en_US&cr=TW&len=425.761&feature=g-high-trv&afmt=251&idpj=-9&ldpj=-34&st=2.11&et=4.102 https://s.youtube.com/api/stats/watchtime?ns=yt&el=detailpage&cpn=7_ujQ21n80-Ke3AR&docid=qoPupXWVhAw&ver=2&referrer=https%3A%2F%2Fwww.youtube.com%2F&cmt=4.102&plid=AAVQaYo0O91_Flkq&ei=L-4nWYedNsqf4AKAxKqoBw&fmt=243&fs=0&rt=5.196&of=L_PUY4Nf_LYjMBZyfTtRvg&euri&lact=5753&cl=156902750&state=paused&vm=CAEQABgE&c=WEB&cver=1.20170523&cplayer=UNIPLAYER&cbr=Firefox&cbrver=55.0&cos=X11&final=1&hl=en_US&cr=TW&len=425.761&feature=g-high-trv&afmt=251&idpj=-9&ldpj=-34&st=2.11&et=4.102 https://www.youtube.com/watch?v=qoPupXWVhAw https://www.youtube.com/ https://www.youtube.com/ https://www.youtube.com/ https://www.youtube.com/ https://s.youtube.com/api/stats/qoe?event=streamingstats&fmt=243&afmt=251&cpn=7_ujQ21n80-Ke3AR&ei=L-4nWYedNsqf4AKAxKqoBw&el=detailpage&docid=qoPupXWVhAw&ns=yt&fexp=9406012%2C9419452%2C9422596%2C9431012%2C9434046%2C9434289%2C9434800%2C9441147%2C9444902%2C9446054%2C9446364%2C9449243%2C9453897%2C9456640%2C9457020%2C9457141%2C9463594%2C9463721%2C9463965%2C9464489%2C9465373%2C9465813%2C9465919%2C9466777%2C9466777%2C9466793%2C9466795%2C9466797%2C9467217%2C9468797%2C9468800%2C9468805%2C9469224%2C9475511%2C9475533%2C9475565%2C9475806%2C9475832%2C9476328%2C9476412%2C9476507%2C9476917%2C9477080%2C9477370%2C9477390%2C9477644%2C9477681&cl=156902750&seq=2&c=WEB&cver=1.20170523&cplayer=UNIPLAYER&cbr=Firefox&cbrver=55.0&cos=X11&cmt=0.077:0.000,0.947:0.000,5.198:4.102&vps=0.077:B,0.947:PL,5.198:N&aft=1496&bwm=5.198:1487255:1.159&bwe=5.198:4018357&bh=5.198:16.164&vis=5.198:3 https://s.youtube.com/api/stats/qoe?event=streamingstats&fmt=243&afmt=251&cpn=7_ujQ21n80-Ke3AR&ei=L-4nWYedNsqf4AKAxKqoBw&el=detailpage&docid=qoPupXWVhAw&ns=yt&fexp=9406012%2C9419452%2C9422596%2C9431012%2C9434046%2C9434289%2C9434800%2C9441147%2C9444902%2C9446054%2C9446364%2C9449243%2C9453897%2C9456640%2C9457020%2C9457141%2C9463594%2C9463721%2C9463965%2C9464489%2C9465373%2C9465813%2C9465919%2C9466777%2C9466777%2C9466793%2C9466795%2C9466797%2C9467217%2C9468797%2C9468800%2C9468805%2C9469224%2C9475511%2C9475533%2C9475565%2C9475806%2C9475832%2C9476328%2C9476412%2C9476507%2C9476917%2C9477080%2C9477370%2C9477390%2C9477644%2C9477681&cl=156902750&seq=2&c=WEB&cver=1.20170523&cplayer=UNIPLAYER&cbr=Firefox&cbrver=55.0&cos=X11&cmt=0.077:0.000,0.947:0.000,5.198:4.102&vps=0.077:B,0.947:PL,5.198:N&aft=1496&bwm=5.198:1487255:1.159&bwe=5.198:4018357&bh=5.198:16.164&vis=5.198:3 https://www.youtube.com/watch?v=qoPupXWVhAw https://www.youtube.com/ https://www.youtube.com/ https://www.youtube.com/ https://www.youtube.com/ nsStringStats => mAllocCount: 168991 => mReallocCount: 8698 => mFreeCount: 168929 -- LEAKED 62 !!! => mShareCount: 133552 => mAdoptCount: 7488 => mAdoptFreeCount: 7485 -- LEAKED 3 !!! => Process ID: 1098, Thread ID: 139888771217216
Updated•7 years ago
|
Priority: -- → P1
Reporter | ||
Comment 1•7 years ago
|
||
I just want to confirm the leak is caused by media side so I do some experiments... ==== under e10s ==== 1. I open "about:config" and modified any of preferences then close the firefox. I got bunches of "leaked url" msg. 2. I open www.google.com and search for any of keywords then close the firefox, I got bunches of "leaked url" msg either. As a result, This bug is not for media playback. Please consider to lower down the priority.
Reporter | ||
Comment 2•7 years ago
|
||
Hi Blake, According to the comment 1, This leak msg is not related to media. Would you please kindly help to find the right person to see if it is really a bug or false alarm leak message? Thank you.
Flags: needinfo?(bwu)
Comment 3•7 years ago
|
||
TingYu, Per discussion, please help have a look. Thanks!
Flags: needinfo?(bwu) → needinfo?(janus926)
Comment 4•7 years ago
|
||
I can't reproduce with debug build on Linux for the latest m-c a418121d4625.
Flags: needinfo?(janus926) → needinfo?(jacheng)
Comment 5•7 years ago
|
||
Sorry, I just tried some more times and can reproduce.
Flags: needinfo?(jacheng)
Updated•7 years ago
|
Whiteboard: [MemShrink]
Updated•7 years ago
|
Assignee: nobody → janus926
Updated•7 years ago
|
Component: Audio/Video: Playback → General
Summary: Got leak message when closing the firefox while playback with only one tab → Got leak messages when close firefox that has only one tab
Updated•7 years ago
|
Summary: Got leak messages when close firefox that has only one tab → Got leak messages when close firefox
Comment 6•7 years ago
|
||
The GC/CC log captured by MOZ_CC_LOG_SHUTDOWN when the console shows: Leaked URLs: https://www.google.com/search?q=abc&ie=utf-8&oe=utf-8 https://www.google.com.tw/search?q=abc&ie=utf-8&oe=utf-8&gws_rd=cr&ei=HE1jWdL0HYfJ0gTN4oiIBw https://www.google.com.tw/search?q=abc&ie=utf-8&oe=utf-8&gws_rd=cr&ei=HE1jWdL0HYfJ0gTN4oiIBw https://www.google.com.tw/gen_204?atyp=i&ct=slh&cad=&ei=HE1jWausKIPY0gTuk4-YDg&m=HV&t=C&s=1&v=2&pv=0.32085084791343477&me=1:1499680030681,x:6,V,0,0,1280,899:0,N,1,HE1jWausKIPY0gTuk4-YDg:0,R,1,3,13,22,120,47:0,R,1,40,166,175,600,94:0,R,1,51,166,295,600,40:0,R,1,53,166,361,600,94:0,R,1,56,166,481,600,76:0,R,1,63,166,585,600,494:0,R,1,65,150,585,632,494:0,R,1,66,150,585,632,200:0,R,1,179,820,175,336,308:0,R,1,180,822,175,366,37:0,R,1,182,822,212,366,88:0,R,1,186,822,300,366,88:0,R,1,188,822,388,366,88:5,B,2210:693,S,64:507,S,221:0,R,1,113,166,1118,600,155:1114,e,H&zx=1499680033009 https://www.google.com.tw/ nsStringStats => mAllocCount: 39306 => mReallocCount: 1265 => mFreeCount: 39267 -- LEAKED 39 !!! => mShareCount: 41025 => mAdoptCount: 2986 => mAdoptFreeCount: 2986 => Process ID: 13641, Thread ID: 139846028789568
Comment 7•7 years ago
|
||
The leak is in child process, but with following command I got only CC/GC log from parent: XPCOM_MEM_LEAK_LOG=1 MOZ_CC_LOG_PROCESS="all" MOZ_CC_LOG_SHUTDOWN=1 MOZ_CC_ALL_TRACES="shutdown" MOZ_CC_LOG_DIRECTORY="~/w/fx/mc/cclog" MOZ_DISABLE_CONTENT_SANDBOX=1 ./mach run
Updated•7 years ago
|
Attachment #8885088 -
Attachment is obsolete: true
Comment 8•7 years ago
|
||
(In reply to Ting-Yu Chou [:ting] from comment #7) > The leak is in child process, but with following command I got only CC/GC > log from parent: That's because MOZ_CCL_LOG_DIRECTORY is a relative path (~/...), and getting home directory [1] is prohibited [2] during shutdown. Using an absolute path would work. [1] http://searchfox.org/mozilla-central/rev/cbd628b085ac809bf5a536109e6288aa91cbdff0/xpcom/io/nsLocalFileUnix.cpp#298-299 [2] http://searchfox.org/mozilla-central/rev/cbd628b085ac809bf5a536109e6288aa91cbdff0/xpcom/components/nsComponentManager.cpp#1379-1388
Comment 9•7 years ago
|
||
Yeah, I've noticed similar issues for a long time, where if you close the browser while a tab is open, you leak pages. I'm not sure how much of an issue it really will be (as long as we clean things up when you close the tab, it should be okay), but I've also never looked into it.
Updated•7 years ago
|
Whiteboard: [MemShrink] → [MemShrink:P3]
Comment 10•7 years ago
|
||
This is an assigned P1 bug without activity in two weeks. If you intend to continue working on this bug for the current release/iteration/sprint, remove the 'stale-bug' keyword. Otherwise we'll reset the priority of the bug back to '--' on Monday, August 28th.
Keywords: stale-bug
Updated•7 years ago
|
Assignee: janus926 → nobody
Reporter | ||
Comment 11•7 years ago
|
||
By using Mozregression, I run it three times and it indicates the leak is caused by Bug 1360198 - don't set artifact expiry in generic-worker tasks if equal to task expiry,r=dustin I would like to try if I could do some validation to ensure it is right patch.
Reporter | ||
Comment 12•7 years ago
|
||
The patch is not related to this issue. Should do more investigation.
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•