Closed
Bug 1368443
Opened 7 years ago
Closed 7 years ago
Fix localization comment and variables for searchResults.needHelp2
Categories
(Firefox :: Settings UI, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: flod, Assigned: flod)
References
Details
Attachments
(1 file)
(In reply to Francesco Lodolo [:flod] from comment #14) > # LOCALIZATION NOTE %S gets replaced with the browser name > searchResults.needHelp2=Need help? Visit <html:a id="need-help-link" > target="_blank" href="%S">%S Support</html:a> > > I seriously doubt that localization comment is now correct. Please remember > to a) update localization comments when you touch a string b) use ordered > arguments when there's more than one. Not changing string ID since %1$S and %S are interchangeable.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8872294 [details] Bug 1368443 - Update localization comment for searchResults.needHelp2, use ordered variables https://reviewboard.mozilla.org/r/143796/#review147488
Attachment #8872294 -
Flags: review?(l10n) → review+
Pushed by francesco.lodolo@mozillaitalia.org: https://hg.mozilla.org/integration/autoland/rev/abd213bb84d4 Update localization comment for searchResults.needHelp2, use ordered variables r=Pike
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/abd213bb84d4
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in
before you can comment on or make changes to this bug.
Description
•